Fix: Don’t use executeCommand on python sub-shell for windows. - #24542
Merged
Anthony Kim (anthonykim1) merged 7 commits intoDec 4, 2024
Conversation
Anthony Kim (anthonykim1)
added
bug
Anthony Kim (anthonykim1)
changed the title
Karthik Nadig (karthiknadig)
changed the title
Anthony Kim (anthonykim1)
marked this pull request as ready for review
December 4, 2024 03:46
Anthony Kim (anthonykim1)
enabled auto-merge (squash)
December 4, 2024 03:54
Karthik Nadig (karthiknadig)
approved these changes
Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #24418
Further resolves: #24422
Shell integration does not exist on windows python repl so dont use execute command on python subshell in this case.
This will prevent keyboard interrupt from happening even when setting for shell integration is enabled for python shell (which is currently only supported on mac and linux)