Launch Native REPL using terminal link - #24734
Conversation
Anthony Kim (anthonykim1)
changed the title
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
| if sys.platform != "win32" and (not is_wsl) and use_shell_integration: | ||
| sys.ps1 = PS1() | ||
|
|
||
| if sys.platform == "darwin": |
There was a problem hiding this comment.
is it weird if only part of this string is fixed to create a link with l10n? Will that translate only half the command?
There was a problem hiding this comment.
Do you mean tooltip: l10n.t('Launch VS Code Native REPL'), part?
I think the the tooltip would only show Launch VS Code Native REPL
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
Karthik Nadig (karthiknadig)
left a comment
Karthik Nadig (karthiknadig)
left a comment
There was a problem hiding this comment.
Missing test
Karthik Nadig (karthiknadig)
changed the title
Karthik Nadig (karthiknadig)
changed the title
| assert.isNotNull(links, 'Expected links to be not undefined'); | ||
| assert.isArray(links, 'Expected links to be an array'); |
There was a problem hiding this comment.
You should check link.command here and validate start and end lengths. if you put the localized string in localize.ts then you can verify tooltip.
You also need a negative test case.
|
just realized this has been non-draft mode. Sorry for the spam everyone :) |
|
I'm going to delete the outdated comments mentioned in the test file in separate PR. |
3 participants
Resolves: #24270
Perhaps further improve via #24270 (comment) ?