Update new file to create a new file - #155544
Conversation
Benjamin Pasero (bpasero)
left a comment
Benjamin Pasero (bpasero)
left a comment
There was a problem hiding this comment.
I like the direction.
There is now 2 somewhat similar commands for creating a file btw:
| return; | ||
| } | ||
|
|
||
| await fileService.createFile(saveUri); |
There was a problem hiding this comment.
Unless you set overwrite: true, this will throw an error if the file exists.
There was a problem hiding this comment.
Will investigate to see what that experience is like. I assume the native save dialog would warn you so it wouldn't be unexpected if we overwrite
There was a problem hiding this comment.
This is a bit weird. So all the files are greyed out and if you select one it doesn't have a prompt saying this file will be overwritten. I'm not sure in this case then if it is safe to overwrite the file or if we should just fail out
I should look into how to avoid showing this in the command palette since this is only part of the |
2 participants
Ideally with
New File...we want the user to also be able to input a filename to create a file.This will allow the creation of a file with a given file name using a best guess URI.
Benjamin Pasero (@bpasero) I assigned you since you mentioned the hot exit concerns I figured you might have insight into concerns surrounding the way I select a URI and create a file on disk.