Show loading for task building status bar icon - #155616
Merged
Merged
Conversation
Daniel Imms (Tyriar)
requested review from
Benjamin Pasero (bpasero) and
Miguel Solorio (miguelsolorio)
July 19, 2022 13:56
Benjamin Pasero (bpasero)
suggested changes
Jul 19, 2022
Miguel Solorio (miguelsolorio)
previously approved these changes
Jul 19, 2022
Miguel Solorio (miguelsolorio)
left a comment
Miguel Solorio (miguelsolorio)
left a comment
Contributor
There was a problem hiding this comment.
From a consistency standpoint, I like the change 👍
Benjamin Pasero (bpasero)
approved these changes
Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153935
Benjamin Pasero (@bpasero) I didn't spend too long on the shape of the options to wait for the owner's desired interface (which I think is you looking at blame)