Drop in CodeAction Menu w/List Widget #152913 - #155666
Merged
Justin Chen (justschen) merged 38 commits intoJul 20, 2022
Merged
Conversation
Collaborator
Author
|
Currently also has an odd bug when turning on and off the experimental setting where the first item in the list will not be highlighted. |
Matt Bierner (mjbvz)
suggested changes
Jul 19, 2022
Matt Bierner (mjbvz)
left a comment
Matt Bierner (mjbvz)
left a comment
Contributor
There was a problem hiding this comment.
Take a first look through! Looks like things are going in the right direction but some parts need a little polishing up
Let me know if you have any questions about the comments
SteVen Batten (sbatten)
self-requested a review
July 20, 2022 18:07
Matt Bierner (mjbvz)
approved these changes
Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #152913.
Currently under experimental setting (Editor › Contrib › Experimental › Code Action Widget)
Has some minor issues with some specific color themes.