Skip to content

editors - limit length of error message (#155337) #155705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Benjamin Pasero (bpasero) merged 1 commit into from
Jul 20, 2022
Merged

editors - limit length of error message (#155337) #155705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/vs/workbench/browser/parts/editor/editorPlaceholder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import { Codicon } from 'vs/base/common/codicons';
import { FileChangeType, FileOperationError, FileOperationResult, IFileService } from 'vs/platform/files/common/files';
import { isErrorWithActions, toErrorMessage } from 'vs/base/common/errorMessage';
import { IDialogService } from 'vs/platform/dialogs/common/dialogs';
import { truncate } from 'vs/base/common/strings';

export interface IEditorPlaceholderContents {
icon: string;
Expand All @@ -48,6 +49,8 @@ export interface IErrorEditorPlaceholderOptions extends IEditorOptions {

export abstract class EditorPlaceholder extends EditorPane {

private static readonly PLACEHOLDER_LABEL_MAX_LENGTH = 1024;

private container: HTMLElement | undefined;
private scrollbar: DomScrollableElement | undefined;
private inputDisposable = this._register(new MutableDisposable());
Expand Down Expand Up @@ -96,6 +99,7 @@ export abstract class EditorPlaceholder extends EditorPane {
// Delegate to implementation for contents
const disposables = new DisposableStore();
const { icon, label, actions } = await this.getContents(input, options, disposables);
const truncatedLabel = truncate(label, EditorPlaceholder.PLACEHOLDER_LABEL_MAX_LENGTH);

// Icon
const iconContainer = container.appendChild($('.editor-placeholder-icon-container'));
Expand All @@ -105,11 +109,11 @@ export abstract class EditorPlaceholder extends EditorPane {
// Label
const labelContainer = container.appendChild($('.editor-placeholder-label-container'));
const labelWidget = document.createElement('span');
labelWidget.textContent = label;
labelWidget.textContent = truncatedLabel;
labelContainer.appendChild(labelWidget);

// ARIA label
container.setAttribute('aria-label', `${computeEditorAriaLabel(input, undefined, this.group, undefined)}, ${label}`);
container.setAttribute('aria-label', `${computeEditorAriaLabel(input, undefined, this.group, undefined)}, ${truncatedLabel}`);

// Actions
const actionsContainer = container.appendChild($('.editor-placeholder-actions-container'));
Expand Down