Skip to content

Add Python Shell Type and .python_history - #204680

Merged
Anthony Kim (anthonykim1) merged 25 commits into
microsoft:mainfrom
anthonykim1:PythonShellHistory
Feb 15, 2024
Merged

Add Python Shell Type and .python_history#204680
Anthony Kim (anthonykim1) merged 25 commits into
microsoft:mainfrom
anthonykim1:PythonShellHistory

Conversation

@anthonykim1

@anthonykim1 Anthony Kim (anthonykim1) commented Feb 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Resolves: microsoft/vscode-python#22878 microsoft/vscode-python#22780

  • Adding Python shell types and adding fetch history to access and show user's ~/.python_history.
  • ~/.python_history stores Python command history line by line. This file gets refreshed for every instance of Python REPL, where session ends with exit()
  • Having Python shell type defined, we are now able to get session history that respect/distinguish Python shell type from user's shell that executes Python shell type such as zsh, bash, pwsh, etc.

@anthonykim1
remove one comment
e3d444d
@anthonykim1
remove unncessary
7140126
@anthonykim1
Why can't I manually override setShellType
cd4c648
@Tyriar
Detect python shell type on Windows
24af1d4
@anthonykim1
fire shellType in _sendProcessTitle
18b82f1
@Tyriar @anthonykim1
Detect python shell type on Windows
c2d2434
@anthonykim1
delete comment
a139138
@anthonykim1
Merge pull request #1 from microsoft/PythonShellHistory
39b2ffb 
Python shell history
@anthonykim1
remove more comments
9ea5d05
@anthonykim1
Merge branch 'microsoft:PythonShellHistory' into PythonShellHistory
b9e3208
@anthonykim1
remove comment
b7f7079
@anthonykim1
Merge branch 'microsoft:PythonShellHistory' into PythonShellHistory
16f2804
@anthonykim1
remove dup
e2fb0a5
@anthonykim1
Merge pull request #2 from microsoft/PythonShellHistory
4933817 
Python shell history
@anthonykim1
clean up
9a9bde5
@anthonykim1
more comprehensive regex for windows python
14fc736
@anthonykim1
follow previous style for map key name
fb845b3
@anthonykim1
remove unused variable
cd0553b
@anthonykim1
remove comment
8b509bb
@anthonykim1
last cleanup
70d8847
@anthonykim1
More cleanup
e94472c
@anthonykim1
more clean up
a356935
@anthonykim1
re-arrange
b928d97
@anthonykim1
Anthony Kim (anthonykim1) marked this pull request as ready for review February 15, 2024 19:05
@vscodenpa VS Code Bot (vscodenpa) added this to the February 2024 milestone Feb 15, 2024
@anthonykim1

Anthony Kim (anthonykim1) commented Feb 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Daniel Imms (@Tyriar) I'm planning to add type for Julia and NuShell in subsequent PR.

@anthonykim1
Anthony Kim (anthonykim1) merged commit d30f701 into microsoft:main Feb 15, 2024
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lramos15 Logan Ramos (lramos15) lramos15 approved these changes
@rzhao271 Raymond Zhao (rzhao271) rzhao271 approved these changes
@Tyriar Daniel Imms (Tyriar) Awaiting requested review from Tyriar

Assignees

@anthonykim1 Anthony Kim (anthonykim1)

Labels

None yet

Projects

None yet

Milestone

February 2024

Development

Successfully merging this pull request may close these issues.

Support Python REPL Shell File History

5 participants

@anthonykim1 @lramos15 @rzhao271 @vscodenpa @Tyriar