Skip to content

update possible javascript/typescript regex flags from dgimsuy to dgimsuvy in textmate grammars#232168

Closed
nnmrts wants to merge 4 commits into
microsoft:mainfrom
nnmrts:dgimsuy-to-dgimsuvy
Closed

update possible javascript/typescript regex flags from dgimsuy to dgimsuvy in textmate grammars#232168
nnmrts wants to merge 4 commits into
microsoft:mainfrom
nnmrts:dgimsuy-to-dgimsuvy

Conversation

@nnmrts
Copy link
Copy Markdown

@nnmrts nnmrts commented Oct 24, 2024

Reopened from #206580 because TypeScript-TmLanguage is unmaintained (microsoft/TypeScript-TmLanguage#1006 - no response for 10 months, microsoft/TypeScript-TmLanguage#1032 - no response for 4 months).

The v flag is supported in major browsers for more than a year now. If this PR won't be accepted, please explain how the dependency on TypeScript-TmLanguage can be replaced within VSCode or the TypeScript extension.

@mjbvz mjbvz added this to the November 2024 milestone Oct 24, 2024
@mjbvz
Copy link
Copy Markdown
Collaborator

mjbvz commented Oct 30, 2024

Pulled in upstream change with 2105419

@mjbvz mjbvz closed this Oct 30, 2024
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants