add references to ChatReferenceBinaryData - #238516
Merged
Merged
Conversation
Justin Chen (justschen)
marked this pull request as ready for review
January 23, 2025 00:50
Contributor
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
roblourens
reviewed
Jan 23, 2025
roblourens
reviewed
Jan 23, 2025
roblourens
reviewed
Jan 23, 2025
| } | ||
|
|
||
| if (/\.(png|jpg|jpeg|bmp|gif|tiff)$/i.test(editor.resource.path)) { | ||
| if (/\.(png|jpg|jpeg|gif|webp)$/i.test(editor.resource.path)) { |
Collaborator
Author
There was a problem hiding this comment.
CAPI doesn't supports BMP and TIFF atm, but now suppports webp
roblourens
approved these changes
Jan 23, 2025
Henry (HD787)
pushed a commit
to HD787/vscode
that referenced
this pull request
Jan 24, 2025
* add reference to binary data api * remove comment * fix tests * fix tests try microsoft#2 * more testing * commenting out for testing * add back history filter * add under isimage check * some fixes * make sure to dispose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related https://github.com/microsoft/vscode-copilot/pull/12078