Skip to content

Important fix for resource validation in MCP - #259089

Merged
Tyler James Leonhardt (TylerLeonhardt) merged 1 commit into
mainfrom
tyler/increased-cow
Jul 31, 2025
Merged

Important fix for resource validation in MCP#259089
Tyler James Leonhardt (TylerLeonhardt) merged 1 commit into
mainfrom
tyler/increased-cow

Conversation

@TylerLeonhardt

@TylerLeonhardt Tyler James Leonhardt (TylerLeonhardt) commented Jul 31, 2025

Copy link
Copy Markdown
Member

In this example:

MCP url: https://foo.com/mcp
WWW-Auth resource_metadata: https://foo.com/laugh/in/the/face/of/conventions.json
PRM: https://foo.com/laugh/in/the/face/of/conventions.json
PRM resource property: https://foo.com/mcp

I use to do:
a URL derived from "WWW-Auth resource_metadata" (which is actually just PRM) is compared to "PRM resource property"

but instead it should be:

"MCP url" compared to "PRM resource property"

Which is what this PR addresses

ref https://datatracker.ietf.org/doc/html/rfc9728#section-3.3

In this example:

MCP url: https://foo.com/mcp
WWW-Auth resource_metadata: https://foo.com/laugh/in/the/face/of/conventions.json
PRM: https://foo.com/laugh/in/the/face/of/conventions.json
PRM resource property: https://foo.com/mcp

I use to do:
a URL derived from "WWW-Auth resource_metadata" (which is actually just PRM) is compared to "PRM resource property"

but instead it should be:

"MCP url" compared to "PRM resource property"

Which is what this PR addresses
@TylerLeonhardt
Tyler James Leonhardt (TylerLeonhardt) merged commit 8aa5d2f into main Jul 31, 2025
18 checks passed
@TylerLeonhardt
Tyler James Leonhardt (TylerLeonhardt) deleted the tyler/increased-cow branch July 31, 2025 23:01
ghost pushed a commit to borisdan/mcp-audit-extension that referenced this pull request Aug 13, 2025
…, proxy MCP Server's PRM endpoint through our gateway

temp
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Sep 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants