Add .agents workspace and personal path support for prompts, instructions, hooks, and agents#318195
Open
cgorican wants to merge 2 commits into
Open
Add .agents workspace and personal path support for prompts, instructions, hooks, and agents#318195cgorican wants to merge 2 commits into
cgorican wants to merge 2 commits into
Conversation
… and hooks Co-authored-by: Catacomba <kevinsuc16@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for .agents/* workspace locations for prompt-related files and updates chat configuration defaults to derive enabled source folders from the centralized default folder lists.
Changes:
- Introduced
.agents/agents,.agents/prompts,.agents/instructions, and.agents/hooksfolder constants and included them in the relevant default source folder arrays. - Updated configuration defaults to be generated from
DEFAULT_*_SOURCE_FOLDERSinstead of hardcoded per-folder keys.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/promptSyntax/config/promptFileLocations.ts | Defines .agents/* folder constants and wires them into default source folder lists for instructions, prompts, agents, and hooks. |
| src/vs/workbench/contrib/chat/browser/chat.shared.contribution.ts | Switches configuration “default enabled folders” objects to be derived from the default folder arrays. |
| ), | ||
| default: { | ||
| [PROMPT_DEFAULT_SOURCE_FOLDER]: true, | ||
| ...DEFAULT_PROMPT_SOURCE_FOLDERS.map((folder) => ({ [folder.path]: true })).reduce((acc, curr) => ({ ...acc, ...curr }), {}), |
Author
There was a problem hiding this comment.
Kept this approach to maintain consistency with the surrounding field implementations.
| [AGENTS_SOURCE_FOLDER]: true, | ||
| [CLAUDE_AGENTS_SOURCE_FOLDER]: true, | ||
| [COPILOT_USER_AGENTS_SOURCE_FOLDER]: true, | ||
| ...DEFAULT_AGENT_SOURCE_FOLDERS.map((folder) => ({ [folder.path]: true })).reduce((acc, curr) => ({ ...acc, ...curr }), {}), |
Author
There was a problem hiding this comment.
Kept this approach to maintain consistency with the surrounding field implementations.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for resolving
.agentsworkspace folder paths for:Skills were already supported previously, so this change brings the remaining workspace resource types to feature parity.
Changes
.agentsworkspace path handling for agent resourcesMotivation
This improves consistency across workspace resource loading and enables all supported resource types to be discovered from the
.agentsworkspace structure.