release/1.122: catch up to verified Insiders build (183159e)#318394
Merged
anthonykim1 merged 1 commit intoMay 26, 2026
Conversation
Squashed cherry-pick of 10 commits from main that are included in the Insiders build (183159e) people are verifying: - agentHost: show fetched URL for web_fetch (#318240) - Fix SSH remote agent host passphrase auth (#318244) - agentHost: add setting to disable worktreeCreated task auto-dispatch (#318243) - Agent host: clearer worktree git timeout errors and 60s budget (#318242) - Normalize LF to CRLF in agent host terminal tool output (#318257) - sessions: restore X-button removal of SSH remote agent host entries (#318262) - chat: fix duplicate command registration for agent-host-copilotcli (#318273) - launch: build copilot in compile; wait for CDP in launch.sh (#318272) - Preserve unread state across remote host disconnect (#318267) - Add more codenotify for terminal (#318285)
bryanchen-d
approved these changes
May 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This release/1.122 pull request is a squash-cherry-pick that brings the branch up to a verified Insiders build, primarily covering agent host UX fixes (tool rendering, git error reporting), SSH remote agent host auth/connectivity improvements, and Agents window session-state correctness across disconnects/reconnects.
Changes:
- Improve agent host tool UX: show
web_fetchURLs, normalize terminal output line endings for xterm rendering, and adjust terminal-tool defaults/tests. - Harden SSH remote agent host behavior: honor
IdentityAgentfromssh -G, prompt for encrypted key passphrases, and fix disconnect/removal sequencing to prevent unintended auto-reconnect. - Improve reliability of session/worktree flows: clearer git timeout handling/budgets, preserve unread/pin state across remote disconnect, and add a setting to gate worktreeCreated task auto-dispatch for agent-host sessions.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/browser/agentSessions/stateToProgressAdapter.test.ts | Adds regression test for LF→CRLF normalization in terminal output rendering. |
| src/vs/workbench/contrib/chat/test/browser/agentSessions/agentHostChatContribution.test.ts | Updates expected terminal output line endings in tests. |
| src/vs/workbench/contrib/chat/electron-browser/chat.contribution.ts | Removes duplicate static command registration for in-place agent-host session open. |
| src/vs/workbench/contrib/chat/browser/chat.shared.contribution.ts | Changes default for agent host custom terminal tool enablement. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/stateToProgressAdapter.ts | Normalizes terminal output newlines to CRLF for xterm stream rendering. |
| src/vs/sessions/SESSIONS_LIST.md | Documents pin/read cleanup semantics vs remote disconnect hiding. |
| src/vs/sessions/contrib/providers/remoteAgentHost/test/browser/remoteAgentHostSessionsProvider.test.ts | Updates tests for session unpublish/restore event semantics and metadata refresh. |
| src/vs/sessions/contrib/providers/remoteAgentHost/test/browser/remoteAgentHost.contribution.test.ts | Adds coverage for SSH disconnect sequencing and connection-key computation. |
| src/vs/sessions/contrib/providers/remoteAgentHost/REMOTE_AGENT_HOST_SESSIONS_PROVIDER.md | Updates provider doc to mention IdentityAgent + encrypted-key passphrase prompting. |
| src/vs/sessions/contrib/providers/remoteAgentHost/browser/remoteAgentHostSessionsProvider.ts | Preserves cached sessions as hidden on disconnect without reporting removals; re-announces on reconnect. |
| src/vs/sessions/contrib/providers/remoteAgentHost/browser/remoteAgentHostActions.ts | Passes resolved IdentityFile/IdentityAgent into SSH connect flows. |
| src/vs/sessions/contrib/providers/remoteAgentHost/browser/remoteAgentHost.contribution.ts | Extracts/uses disconnectSSHEntry + sshConnectionKey to enforce remove-before-disconnect ordering. |
| src/vs/sessions/contrib/providers/agentHost/browser/baseAgentHostSessionsProvider.ts | Allows refresh to optionally announce existing cached sessions as “added”. |
| src/vs/sessions/contrib/chat/test/browser/worktreeCreatedTaskDispatcher.test.ts | Adds tests for new agent-host gating setting for auto-dispatch of worktreeCreated tasks. |
| src/vs/sessions/contrib/chat/browser/worktreeCreatedTaskDispatcher.ts | Adds configuration-gated skip for agent-host worktreeCreated auto-dispatch. |
| src/vs/sessions/contrib/chat/browser/chat.contribution.ts | Registers chat.agentHost.runWorktreeCreatedTasks configuration in Sessions window. |
| src/vs/sessions/common/agentHostSessionsProvider.ts | Introduces isAgentHostProviderId helper and reuses it from isAgentHostProvider. |
| src/vs/platform/agentHost/test/node/sshRemoteAgentHostService.test.ts | Adds IdentityAgent ordering/behavior tests, default-key normalization test, and encrypted-key passphrase test. |
| src/vs/platform/agentHost/test/node/copilotToolDisplay.test.ts | Adds unit coverage for web_fetch URL display/input formatting. |
| src/vs/platform/agentHost/test/node/agentHostGitService.test.ts | Adds unit tests for new git error formatting and stderr summarization helpers. |
| src/vs/platform/agentHost/test/node/agentHostGitService.integrationTest.ts | Updates construction to pass log service into AgentHostGitService. |
| src/vs/platform/agentHost/test/electron-browser/sshRemoteAgentHostService.test.ts | Updates resolved SSH config mock shape to include identityAgent. |
| src/vs/platform/agentHost/test/common/sshConfigParsing.test.ts | Adds parsing coverage for identityagent from ssh -G. |
| src/vs/platform/agentHost/node/sshRemoteAgentHostService.ts | Adds IdentityAgent support, encrypted-key detection + passphrase prompting, and revised auth attempt ordering. |
| src/vs/platform/agentHost/node/copilot/copilotToolDisplay.ts | Adds web_fetch tool display/input formatting with URL markdown link rendering. |
| src/vs/platform/agentHost/node/agentHostGitService.ts | Improves git worktree timeouts, adds structured error formatting, and logs full stderr on failure. |
| src/vs/platform/agentHost/common/sshRemoteAgentHost.ts | Extends SSH config/contracts with identityAgent. |
| src/vs/platform/agentHost/common/sshConfigParsing.ts | Plumbs identityagent through resolved config parsing. |
| package.json | Makes npm run compile also build the Copilot extension via parallel scripts. |
| .github/CODENOTIFY | Adds/expands code-notify ownership entries for terminal-related paths. |
| .agents/skills/launch/SKILL.md | Updates launcher documentation to reflect compile changes + CDP-ready blocking behavior. |
| .agents/skills/launch/scripts/launch.sh | Runs prelaunch in foreground, launches detached, and blocks until CDP endpoint responds (or fails with log tail). |
Copilot's findings
- Files reviewed: 32/32 changed files
- Comments generated: 2
dileepyavan
pushed a commit
that referenced
this pull request
May 27, 2026
Squashed cherry-pick of 10 commits from main that are included in the Insiders build (183159e) people are verifying: - agentHost: show fetched URL for web_fetch (#318240) - Fix SSH remote agent host passphrase auth (#318244) - agentHost: add setting to disable worktreeCreated task auto-dispatch (#318243) - Agent host: clearer worktree git timeout errors and 60s budget (#318242) - Normalize LF to CRLF in agent host terminal tool output (#318257) - sessions: restore X-button removal of SSH remote agent host entries (#318262) - chat: fix duplicate command registration for agent-host-copilotcli (#318273) - launch: build copilot in compile; wait for CDP in launch.sh (#318272) - Preserve unread state across remote host disconnect (#318267) - Add more codenotify for terminal (#318285)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Squashed cherry-pick of 10 commits from main that are included in the Insiders build (183159e) people are verifying:
/cc @federicobrancasi @bryanchen-d