Skip to content

Fix MLTensorUsage is not defined issue - #58

Merged
fdwr merged 1 commit into
microsoft:mainfrom
ibelem:ml-tensor-usage-test-fix
Nov 14, 2024
Merged

Fix MLTensorUsage is not defined issue#58
fdwr merged 1 commit into
microsoft:mainfrom
ibelem:ml-tensor-usage-test-fix

Conversation

@ibelem

@ibelem ibelem commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

Fix #57 with ORT test dists.

Google Chrome 133.0.6835.0 (Official Build) canary (64-bit)

  • stable-diffusion-1.5 - PASS
  • sd-turbo - PASS
  • segment-anything - PASS
  • whisper-base - PASS
  • phi-3-mini - PASS

Will try to build transformers.js dists with ORT test dists in next PR.

  • image-classification - To do

@fdwr PTAL

@fdwr fdwr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - this should fix the immediate break. I presume we'll restore it back to an npmjs release after the next nightly build?

Ningxin also had a related comment here that we can discuss today: microsoft/onnxruntime#22831 (comment)

(It really would be nice to have some way to keep a stable version of the browser that runs a matching build of ORT :/)

@fdwr
fdwr merged commit f971ea3 into microsoft:main Nov 14, 2024
@ibelem

ibelem commented Nov 14, 2024

Copy link
Copy Markdown
Contributor Author

Thanks - this should fix the immediate break. I presume we'll restore it back to an npmjs release after the next nightly build?

Definitely

Ningxin also had a related comment here that we can discuss today: microsoft/onnxruntime#22831 (comment)

(It really would be nice to have some way to keep a stable version of the browser that runs a matching build of ORT :/)

Sure, we can discuss. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MLTensorUsage is not defined in Classification and Whisper

2 participants