Move VARIANT support to the windows crate#3282
Merged
Merged
Conversation
Collaborator
Author
|
It's tricky because |
Collaborator
|
This might be a dumb question but do they need to be in a separate namespace? Or is this something that could reasonably be changed? |
Collaborator
Author
|
Yes, that would greatly simplify this. Arguably they should just be together as the two are interdependent APIs. |
Collaborator
Author
|
It's far from perfect but greatly simplifies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2786 added richer support for
VARIANTandPROPVARIANTand at the time the only practical way to do that was adding it to thewindows-corecrate. But that meant that everyone using thewindows-corecrate carried aroundVARIANTsupport even though that's really only meant for some very old Windows APIs in thewindowscrate. Now that #3110 added a simpler way to handle type extensions, we can more naturally provide this same functionality directly in thewindowscrate, unburdening thewindows-corecrate and simplifying thewindows-metadataandwindows-bindgencrates as well with less "special" type support.