Cleanup old log files

[florelis]

Description of the new feature / enhancement

(Assuming we're not doing it already and I just don't know about it...)

If we're not cleaning up old log files, the log folder will just keep growing in size indefinitely. I frequently delete old logs manually when I'm going through new logs, so I don't know how bad this can get wrt space.

Proposed technical implementation details

No response

[Trenly]

Cleans up after 7 days

winget-cli/src/AppInstallerCLICore/Core.cpp

Lines 83 to 84 in 0a0eebf

	// Initiate the background cleanup of the log file location.
	Logging::FileLogger::BeginCleanup();

winget-cli/src/AppInstallerCommonCore/FileLogger.cpp

Lines 107 to 128 in 0a0eebf

	void FileLogger::BeginCleanup(const std::filesystem::path& filePath)
	{
	std::thread([filePath]()
	{
	try
	{
	auto now = std::filesystem::file_time_type::clock::now();
	// Remove all files that are older than 7 days from the standard log location.
	for (auto& file : std::filesystem::directory_iterator{ filePath })
	{
	if (file.is_regular_file() &&
	now - file.last_write_time() > (7 * 24h))
	{
	std::filesystem::remove(file.path());
	}
	}
	}
	// Just throw out everything
	catch (...) {}
	}).detach();
	}

[florelis]

Oh, nice! Thanks, I didn't know we had that already. Should have tried looking up in the code before opening the issue.

[Gijsreyn]

Hi @mdanish-kh. I know this issue has been closed for a while now, but do you know if this feature was also implemented in the winget-cli? I couldn't find it in the settings.md.

[mdanish-kh]

@Gijsreyn Looking at the code Trenly shared above it seems that it's a hardcoded value of 7 days in the CLI and not something that's configurable through user settings

[Gijsreyn]

Thanks for the quick reply @mdanish-kh . I'll create an issue in this project :)

[Deadooshka]

It creates an empty log file on every winget start with higher log levels. Is it OK?