Improve --include-unknown message

[felipecrs]

• Have you signed the Contributor License Agreement?
• Are you working against an Issue?

---

Here is how it was before:

➜ winget upgrade
Nenhum pacote instalado foi encontrado que corresponda aos critérios de entrada.
10 packages have version numbers that cannot be determined. Use "--include-unknown" to see all results.

➜ winget upgrade --include-unknown
Nenhum pacote instalado foi encontrado que corresponda aos critérios de entrada.

The current message gives the impression that using --include-unknown could potentially show all the 10 packages mentioned, which is a mistake. In fact, it would only show packages who have candidates in the WinGet repo.

So, I'm addressing this with this PR.

But honestly, I would prefer that this was transparent to the user, i.e. not show any message at all about unknown packages.

Refs #1692
Refs #1765

Microsoft Reviewers: Open in CodeFlow

[denelon]

Thanks @felipcrs. Hey @jedieaston just an FYI since you implemented the feature.

[jedieaston]

Thanks for the correction!

I think we should still correct that count to only count things that we have in a repository, but that's another, more complex PR.

[felipecrs]

For some reason I can't sign the CLA:

chrome_GSNx7MaXSC.mp4

[denelon]

For some reason I can't sign the CLA:

I'll reach out to the Open Source Team to see if we can get some help.

[felipecrs]

Also, I have signed it before... it's not my first contribution. :P

Let me try to rebase the PR, to see if it triggers something.

[denelon]

It looks like we may have an outage. Can you point to a previously merged PR so the team can just merge this manually if we need to go that route?

[denelon]

• CLA verification appears to be down. #1947

[felipecrs]

• Create SandboxTest script winget-pkgs#827

It's in the winget-pkgs repo, but I suppose it's the same because of the following URL:

winget-cli/.github/PULL_REQUEST_TEMPLATE.md

Line 1 in d0dae56

- [ ] Have you signed the [Contributor License Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs)?

https://cla.opensource.microsoft.com/microsoft/winget-pkgs

PS: changing it manually to winget-cli does not help.

[denelon]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[felipecrs]

I just signed it now (maybe I haven't signed it before?).

[denelon]

I believe it needs to be signed for each repository. The check is still not responding though.

[felipecrs]

I tried to enter in https://cla.opensource.microsoft.com/microsoft/winget-cli, but it says:

[felipecrs]

I will rebase the PR to see if it helps.

[denelon]

I have no idea what will help at this point. I'm just watching the "license/cla Expected - Waiting for status to be reported" line in the build.

[vedantmgoyal9]

[denelon]

Thanks @felipecrs!

[felipecrs]

Don't mention it! That was a very simple one!

Thanks for WinGet!