Skip to content

Add Experimental Argument for UninstallPrevious in Upgrade Flow#2755

Merged
yao-msft merged 3 commits into
microsoft:masterfrom
Trenly:UninstallPreviousArg
Jan 10, 2023
Merged

Add Experimental Argument for UninstallPrevious in Upgrade Flow#2755
yao-msft merged 3 commits into
microsoft:masterfrom
Trenly:UninstallPreviousArg

Conversation

@Trenly

@Trenly Trenly commented Dec 7, 2022 •
edited by ghost
Loading

Copy link
Copy Markdown
Contributor

Left this just for the upgrade flow (and Installs that switched to using the upgrade flow). May potentially want to consider enabling for default install flow (for when --force) is used. Depends on user feedback and use cases

This will cause a merge conflict with #2733 due to the Experimental Features Enum; If pinning is merged first, I will be happy to rebase this

Microsoft Reviewers: Open in CodeFlow

@Trenly Trenly requested a review from a team as a code owner December 7, 2022 19:23
@yao-msft

yao-msft commented Dec 7, 2022

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelines Bot commented Dec 7, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Trenly

Trenly commented Dec 7, 2022

Copy link
Copy Markdown
Contributor Author

I need to start checking more thoroughly for typos before I push . . .

@florelis

florelis commented Dec 8, 2022

Copy link
Copy Markdown
Member

This will cause a merge conflict with #2733 due to the Experimental Features Enum; If pinning is merged first, I will be happy to rebase this

Looks like I beat you to it, sorry!

@Trenly

Trenly commented Dec 8, 2022

Copy link
Copy Markdown
Contributor Author

This will cause a merge conflict with #2733 due to the Experimental Features Enum; If pinning is merged first, I will be happy to rebase this

Looks like I beat you to it, sorry!

No apology needed :)
I was hoping pinning would be first anyways

@Trenly Trenly force-pushed the UninstallPreviousArg branch from 7b88421 to 6cb58a5 Compare December 9, 2022 13:46
yao-msft
yao-msft reviewed Jan 9, 2023
View reviewed changes

@yao-msft yao-msft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry we reviewed this late as we just had our v1.4 release candidate created last week.

The change looks good. Please merge to the latest when time available. Thanks.

And an open question, since import command also converts to upgrade when needed, does power user want to remove previous for them as well? I guess not, but I'll just leave the question here.

Comment thread src/AppInstallerCLICore/Workflows/InstallFlow.cpp
@Trenly

Trenly commented Jan 10, 2023

Copy link
Copy Markdown
Contributor Author

And an open question, since import command also converts to upgrade when needed, does power user want to remove previous for them as well? I guess not, but I'll just leave the question here.

Possibly; I think it may be best to wait and see if we get feedback on it since I'm not sure how useful it will be in the import scenario

@Trenly Trenly requested a review from yao-msft January 10, 2023 03:10
@yao-msft

yao-msft commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelines Bot commented Jan 10, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@yao-msft yao-msft merged commit 5c6ba96 into microsoft:master Jan 10, 2023
@Trenly Trenly deleted the UninstallPreviousArg branch January 10, 2023 22:08
@Trenly Trenly mentioned this pull request Jan 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yao-msft yao-msft yao-msft approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Trenly @yao-msft @florelis