Feature .Net v2 by andrueastman · Pull Request #382 · microsoftgraph/MSGraph-SDK-Code-Generator

andrueastman · 2021-01-04T07:09:33Z

This PR encompasses work for v2 of dotnet.

Related issues:-

Support move to System.Text.Json on the Service Library msgraph-sdk-dotnet-core#80 (System.Text.Json migration)
Add methods to exposing the GraphResponse object from the Service Library msgraph-sdk-dotnet-core#201 (Add methods for GraphResponse)

# Conflicts: # submodules/vipr

Templates/templates/CSharp/Base/EntityRequest.Base.template.tt

andrueastman · 2021-01-05T06:59:45Z

Updated sample generation microsoftgraph/msgraph-sdk-dotnet@0cc99b2

andrueastman · 2021-01-07T10:03:32Z

TODO

Merge in changes from Support composable functions in .NET #316 once its merged in

Fix the setting of odata.type in the constructor

Make properties of GraphServiceClient virtual

andrueastman · 2021-07-09T07:08:02Z

@baywet @MIchaelMainer Any chance I can get a re-review?
The votes got reset and I would like to merge this in before https://github.com/microsoftgraph/msgraph-sdk-raptor/pull/167 so as not affect raptor tests.

andrueastman · 2021-07-09T12:50:41Z

Just to clarify, microsoftgraph/msgraph-beta-sdk-dotnet#321 and microsoftgraph/msgraph-sdk-dotnet#1058 will have to be merged in first before this is merged in.

...pewriter.Test/TestDataJavaBeta/com/microsoft/graph/requests/WorkbookChartRequestBuilder.java

...ter.Test/TestDataCSharp/com/microsoft/graph2/callrecords/requests/SingletonEntity1Request.cs

...er.Test/TestDataCSharp/com/microsoft/graph2/callrecords/requests/ISingletonEntity1Request.cs

...pewriter.Test/TestDataCSharp/com/microsoft/graph/requests/DirectoryObjectReferenceRequest.cs

test/Typewriter.Test/TestDataCSharp/com/microsoft/graph/model/Group.cs

Templates/templates/CSharp/Requests/IStreamRequest.cs.tt

Templates/templates/CSharp/Requests/IMethodRequest.cs.tt

Templates/templates/CSharp/Requests/IEntityWithReferenceRequest.cs.tt

Templates/templates/CSharp/Requests/EntityCollectionWithReferencesResponse.cs.tt

Templates/templates/CSharp/Base/ICollectionRequest.Base.template.tt

MIchaelMainer · 2021-07-13T18:12:33Z

Will need to review locally. Let's make sure we have an archive branch for the old version of the .NET templates.

Edit: it looks like @baywet already created a support branch, https://github.com/microsoftgraph/MSGraph-SDK-Code-Generator/tree/support/dotnet-3.x. Thank you!

.azure-pipelines/generation-templates/dotnet.yml

Templates/templates/CSharp/Base/ICollectionRequest.Base.template.tt

baywet · 2021-07-14T12:38:17Z

@MIchaelMainer I had nothing to do with that branch besides suggesting it to @andrueastman and making the last commit before the branch was created. Credit goes to Andrew :)

Review feedback from #382

Andrew Omondi added 19 commits November 30, 2020 16:24

Adds new annotations for system.text.json

367ab59

Add type parameter for derived type converter

f7419f1

Remove extra new line

43b2b98

Update enum converter type

f73d450

Remove unnecessary tab

3e04282

First draft of updated files.

ed8d1ca

Merge remote-tracking branch 'origin/dev' into feature/dotnet-v2

4733ea3

Merge remote-tracking branch 'origin/dev' into feature/dotnet-v2

b3cd47c

Fix Interface converter support

bb9c2f8

Use JDocument as default holder

cc009e6

Merge remote-tracking branch 'origin/dev' into feature/dotnet-v2

a21a35f

Merge remote-tracking branch 'origin/dev' into feature/dotnet-v2

78973d7

Fix errors from merge

ef82a7f

Add references support to request builders

8a14d33

Merge branch 'dev' into feature/dotnet-v2

04d56c8

# Conflicts: # submodules/vipr

Update submodule

f2f9d8c

Merge remote-tracking branch 'origin/dev' into feature/dotnet-v2

874716e

Build Templates project

614f19c

update dependency

9aecd2d

andrueastman added the breaking change label Jan 4, 2021

andrueastman self-assigned this Jan 4, 2021

andrueastman added the Do Not Merge PR that are created but are not intended to be merged until some future condition is met. label Jan 4, 2021

baywet reviewed Jan 4, 2021

View reviewed changes

Templates/templates/CSharp/Base/EntityRequest.Base.template.tt Outdated Show resolved Hide resolved

Remove unnecessary stream.FlushAsync

7826a7e

Andrew Omondi added 2 commits January 5, 2021 12:22

Merge remote-tracking branch 'origin/dev' into feature/dotnet-v2

e908181

Merge remote-tracking branch 'origin/dev' into feature/dotnet-v2

7351d9d

baywet previously approved these changes Jan 7, 2021

View reviewed changes

Merge remote-tracking branch 'origin/dev' into feature/dotnet-v2

071e16e

andrueastman and others added 4 commits May 26, 2021 16:57

Merge pull request #534 from microsoftgraph/bugfix/odataTypeCstor

1d0983e

Fix the setting of odata.type in the constructor

Merge remote-tracking branch 'origin/dev' into feature/dotnet-v2

a26306b

Make properties of GraphServiceClient virtual

3a45c69

Merge pull request #547 from microsoftgraph/andrueastman/virtualProps

54cf309

Make properties of GraphServiceClient virtual

andrueastman removed the Do Not Merge PR that are created but are not intended to be merged until some future condition is met. label Jul 8, 2021

andrueastman marked this pull request as ready for review July 8, 2021 07:55

Andrew Omondi added 2 commits July 8, 2021 11:04

Update submodule

9b08df1

Merge remote-tracking branch 'origin/dev' into feature/dotnet-v2

2e6a4c1

baywet suggested changes Jul 13, 2021

View reviewed changes

MIchaelMainer previously approved these changes Jul 13, 2021

View reviewed changes

.azure-pipelines/generation-templates/dotnet.yml Show resolved Hide resolved

Templates/templates/CSharp/Base/ICollectionRequest.Base.template.tt Show resolved Hide resolved

Merge remote-tracking branch 'origin/dev' into reviewFeedback

be93e22

Andrew Omondi added 3 commits July 15, 2021 11:44

PR review feedback

df21f77

Merge remote-tracking branch 'origin/dev' into reviewFeedback

03092b6

Merge remote-tracking branch 'origin/dev' into feature/dotnet-v2

950290e

andrueastman requested a review from ramsessanchez as a code owner July 15, 2021 08:54

andrueastman mentioned this pull request Jul 15, 2021

Review feedback from #382 #562

Merged

Andrew Omondi and others added 3 commits July 15, 2021 11:56

Merge branch 'feature/dotnet-v2' into reviewFeedback

fc84250

Fixes for put references calls

6c643d3

Merge pull request #562 from microsoftgraph/reviewFeedback

13b3f9d

Review feedback from #382

andrueastman dismissed MIchaelMainer’s stale review via 13b3f9d July 15, 2021 14:09

andrueastman requested review from MIchaelMainer and baywet July 15, 2021 14:12

baywet approved these changes Jul 15, 2021

View reviewed changes

andrueastman merged commit 7660577 into dev Jul 21, 2021

andrueastman deleted the feature/dotnet-v2 branch July 21, 2021 15:54

andrueastman mentioned this pull request Jul 21, 2021

Merge dev into main #564

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature .Net v2#382

Feature .Net v2#382
andrueastman merged 109 commits intodevfrom
feature/dotnet-v2

andrueastman commented Jan 4, 2021 •

edited

Loading

Uh oh!

Uh oh!

andrueastman commented Jan 5, 2021 •

edited

Loading

Uh oh!

andrueastman commented Jan 7, 2021 •

edited

Loading

Uh oh!

andrueastman commented Jul 9, 2021

Uh oh!

andrueastman commented Jul 9, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MIchaelMainer commented Jul 13, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

baywet commented Jul 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

andrueastman commented Jan 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

andrueastman commented Jan 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrueastman commented Jan 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrueastman commented Jul 9, 2021

Uh oh!

andrueastman commented Jul 9, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MIchaelMainer commented Jul 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

baywet commented Jul 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

andrueastman commented Jan 4, 2021 •

edited

Loading

andrueastman commented Jan 5, 2021 •

edited

Loading

andrueastman commented Jan 7, 2021 •

edited

Loading

MIchaelMainer commented Jul 13, 2021 •

edited

Loading