Merged
Conversation
Release 3.15.0
Release 3.16
release 3.19.0
Release 3.20
…ns2-part2 Latest run with typewriter post merge
baywet
previously approved these changes
Jan 19, 2021
Whitespace change in templates - latest from typewriter `git diff origin/feature/composableFunctions -I "\s+"`
baywet
approved these changes
Jan 20, 2021
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
I only sampled that but it looks like the only major change (across all builders) was implementing the IBaseRequestBuilder interface
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this pull request
3bdf1b9 - Support composable functions.
2094776 - Add tests
54275a0 - Add SetFunctionParameters() to all methods (oops)
74822c7 - Add IBaseRequestBuilder as the base to all method request interfaces (the same over many files). Adding common base interface to support Microsoft Graph Toolkit.
54db4c0 - editorconfig update
65df838 - Remove SetFunctionParameters() from actions (fix the oops)
c2f6286 - Broke tests that were broken - changes to functions made it so we could fix them.
79f86a9 - Add missing overloads
This won't build with CI until microsoftgraph/msgraph-sdk-dotnet-core#183 is published.
Merge #873 into this branch before merging into dev.
Other links