Skip to content

Feat/large file upload - #231

Merged
rkodev merged 14 commits into
mainfrom
feat/large-file-upload
Feb 28, 2024
Merged

Feat/large file upload#231
rkodev merged 14 commits into
mainfrom
feat/large-file-upload

Conversation

@rkodev

@rkodev rkodev commented Sep 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Overview

Adds support for large file upload
Resolves #12
Resolves microsoftgraph/msgraph-sdk-go#511

Testing

  • Uses unit tests
  • Manuall testing

@sonarqubecloud

sonarqubecloud Bot commented Sep 20, 2023

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@rkodev
rkodev force-pushed the feat/large-file-upload branch 2 times, most recently from 57853e2 to c3f6da5 Compare January 22, 2024 14:13
@rkodev
rkodev force-pushed the feat/large-file-upload branch from 5e39089 to 24d3733 Compare February 5, 2024 10:24
@rkodev
rkodev marked this pull request as ready for review February 5, 2024 10:26
@rkodev
rkodev requested a review from a team as a code owner February 5, 2024 10:26
@rkodev
rkodev force-pushed the feat/large-file-upload branch from 24d3733 to f79e53f Compare February 5, 2024 11:28
andrueastman
andrueastman reviewed Feb 5, 2024
View reviewed changes
Comment thread fileuploader/large_file_upload_task.go
Comment thread fileuploader/file_uploader_util.go Outdated
Comment thread fileuploader/large_file_upload_task.go Outdated
Comment thread fileuploader/large_file_upload_task.go Outdated
Comment thread fileuploader/upload_slice.go Outdated
@rkodev
rkodev force-pushed the feat/large-file-upload branch from 11f8dd0 to 4ab4830 Compare February 7, 2024 13:18
andrueastman
andrueastman reviewed Feb 12, 2024
View reviewed changes
Comment thread fileuploader/large_file_upload_task.go
Comment thread fileuploader/large_file_upload_task.go Outdated
@rkodev
rkodev force-pushed the feat/large-file-upload branch from 4ab4830 to 2373109 Compare February 16, 2024 11:48
@sonarqubecloud

sonarqubecloud Bot commented Feb 28, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@rkodev
rkodev merged commit 1c7ed46 into main Feb 28, 2024
@rkodev
rkodev deleted the feat/large-file-upload branch February 28, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@andrueastman andrueastman andrueastman approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to use this sdk to upload a file using an upload session to OneDrive Add support for large file upload

2 participants

@rkodev @andrueastman