chore: small perf improvements

Signed-off-by: will Farrell <willfarrell@proton.me>

packages/appconfig/index.js

@@ -68,9 +68,10 @@ const appConfigMiddleware = (opts = {}) => {
 			});
 	}
 
+	const fetchDataKeys = Object.keys(options.fetchData);
 	const fetchRequest = (request, cachedValues = {}) => {
 		const values = {};
-		for (const internalKey of Object.keys(options.fetchData)) {
+		for (const internalKey of fetchDataKeys) {
 			if (cachedValues[internalKey]) continue;
 			if (typeof configurationTokenCache[internalKey] === "undefined") {
 				const command = new StartConfigurationSessionCommand(
@@ -113,7 +114,7 @@ const appConfigMiddleware = (opts = {}) => {
 		const { value } = processCache(options, fetchRequest, request);
 		Object.assign(request.internal, value);
 		if (options.setToContext) {
-			const data = await getInternal(Object.keys(options.fetchData), request);
+			const data = await getInternal(fetchDataKeys, request);
 			Object.assign(request.context, data);
 		}
 	};

packages/core/executionModeDurableContext.js

@@ -13,7 +13,7 @@ export const executionModeDurableContext = (
 ) => {
 	const middy = withDurableExecution(async (event, context) => {
 		const request = middyRequest(event, context);
-		plugin.requestStart?.(request);
+		plugin.requestStart(request);
 
 		// normalize context with executionModeStandard
 		// https://docs.aws.amazon.com/lambda/latest/dg/typescript-context.html
@@ -33,7 +33,7 @@ export const executionModeDurableContext = (
 			onErrorMiddlewares,
 			plugin,
 		);
-		await plugin.requestEnd?.(request);
+		await plugin.requestEnd(request);
 		return response;
 	});
 	middy.handler = (replaceLambdaHandler) => {
@@ -44,7 +44,7 @@ export const executionModeDurableContext = (
 };
 
 const copyKeys = (to, from, keys) => {
-	keys.forEach((key) => {
-		to[key] = from[key];
-	});
+	for (let i = 0, len = keys.length; i < len; i++) {
+		to[keys[i]] = from[keys[i]];
+	}
 };

packages/core/executionModeStandard.js

@@ -10,7 +10,7 @@ export const executionModeStandard = (
 ) => {
 	const middy = async (event, context) => {
 		const request = middyRequest(event, context);
-		plugin.requestStart?.(request);
+		plugin.requestStart(request);
 
 		const response = await runRequest(
 			request,
@@ -20,7 +20,7 @@ export const executionModeStandard = (
 			onErrorMiddlewares,
 			plugin,
 		);
-		await plugin.requestEnd?.(request);
+		await plugin.requestEnd(request);
 		return response;
 	};
 	middy.handler = (replaceLambdaHandler) => {

packages/core/executionModeStreamifyResponse.js

@@ -16,7 +16,7 @@ export const executionModeStreamifyResponse = (
 	const middy = awslambda.streamifyResponse(
 		async (event, lambdaResponseStream, context) => {
 			const request = middyRequest(event, context);
-			plugin.requestStart?.(request);
+			plugin.requestStart(request);
 			const handlerResponse = await runRequest(
 				request,
 				beforeMiddlewares,
@@ -55,7 +55,7 @@ export const executionModeStreamifyResponse = (
 			}
 
 			await pipeline(handlerStream, responseStream);
-			await plugin.requestEnd?.(request);
+			await plugin.requestEnd(request);
 		},
 	);
 

packages/core/index.js

@@ -4,6 +4,7 @@ import { setTimeout } from "node:timers";
 import { executionModeStandard } from "./executionModeStandard.js";
 
 const defaultLambdaHandler = () => {};
+const noop = () => {};
 const defaultPluginConfig = {
 	timeoutEarlyInMillis: 5,
 	timeoutEarlyResponse: () => {
@@ -29,6 +30,14 @@ export const middy = (setupLambdaHandler, pluginConfig) => {
 	}
 	plugin.timeoutEarly = plugin.timeoutEarlyInMillis > 0;
 
+	// Pre-compute single-call plugin hooks as noop to avoid optional chaining
+	// Note: beforeMiddleware/afterMiddleware kept as optional chaining in runMiddlewares
+	// because V8 optimizes ?.() null-checks faster than noop calls in tight loops
+	plugin.requestStart ??= noop;
+	plugin.requestEnd ??= noop;
+	plugin.beforeHandler ??= noop;
+	plugin.afterHandler ??= noop;
+
 	plugin.beforePrefetch?.();
 	const beforeMiddlewares = [];
 	const afterMiddlewares = [];
@@ -115,7 +124,7 @@ const runRequest = async (
 
 		// Check if before stack hasn't exit early
 		if (!Object.hasOwn(request, "earlyResponse")) {
-			plugin.beforeHandler?.();
+			plugin.beforeHandler();
 
 			// Can't manually abort and timeout with same AbortSignal
 			// https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal/timeout_static
@@ -154,7 +163,7 @@ const runRequest = async (
 				clearTimeout(timeoutID);
 			}
 
-			plugin.afterHandler?.();
+			plugin.afterHandler();
 			await runMiddlewares(request, afterMiddlewares, plugin);
 		}
 	} catch (err) {
@@ -182,11 +191,11 @@ const runRequest = async (
 	return request.response;
 };
 
-const runMiddlewares = async (request, middlewares, pluginConfig) => {
+const runMiddlewares = async (request, middlewares, plugin) => {
 	for (const nextMiddleware of middlewares) {
-		pluginConfig.beforeMiddleware?.(nextMiddleware.name);
+		plugin.beforeMiddleware?.(nextMiddleware.name);
 		const res = await nextMiddleware(request);
-		pluginConfig.afterMiddleware?.(nextMiddleware.name);
+		plugin.afterMiddleware?.(nextMiddleware.name);
 		// short circuit chaining and respond early
 		if (typeof res !== "undefined") {
 			request.earlyResponse = res;

packages/dynamodb/index.js

@@ -32,16 +32,17 @@ const dynamodbMiddleware = (opts = {}) => {
 		fetchData: structuredClone({ ...defaults.fetchData, ...opts.fetchData }),
 	};
 
+	const fetchDataKeys = Object.keys(options.fetchData);
 	// force marshall of Key during cold start
-	for (const internalKey of Object.keys(options.fetchData)) {
+	for (const internalKey of fetchDataKeys) {
 		options.fetchData[internalKey].Key = marshall(
 			options.fetchData[internalKey].Key,
 		);
 	}
 
 	const fetchRequest = (request, cachedValues = {}) => {
 		const values = {};
-		for (const internalKey of Object.keys(options.fetchData)) {
+		for (const internalKey of fetchDataKeys) {
 			if (cachedValues[internalKey]) continue;
 			const inputParameters = options.fetchData[internalKey];
 			const command = new GetItemCommand(inputParameters);
@@ -71,7 +72,7 @@ const dynamodbMiddleware = (opts = {}) => {
 		const { value } = processCache(options, fetchRequest, request);
 		Object.assign(request.internal, value);
 		if (options.setToContext) {
-			const data = await getInternal(Object.keys(options.fetchData), request);
+			const data = await getInternal(fetchDataKeys, request);
 			Object.assign(request.context, data);
 		}
 	};

packages/http-content-encoding/index.js

@@ -5,9 +5,13 @@ import { Readable } from "node:stream";
 import { ReadableStream } from "node:stream/web";
 import {
 	createBrotliCompress as brotliCompressStream,
+	brotliCompressSync,
 	createDeflate as deflateCompressStream,
+	deflateSync,
 	createGzip as gzipCompressStream,
+	gzipSync,
 	createZstdCompress as zstdCompressStream,
+	zstdCompressSync,
 } from "node:zlib";
 import { normalizeHttpResponse } from "@middy/util";
 
@@ -18,6 +22,13 @@ const contentEncodingStreams = {
 	zstd: zstdCompressStream,
 };
 
+const contentEncodingSync = {
+	br: brotliCompressSync,
+	deflate: deflateSync,
+	gzip: gzipSync,
+	zstd: zstdCompressSync,
+};
+
 const defaults = {
 	br: undefined,
 	deflate: undefined,
@@ -67,21 +78,19 @@ const httpContentEncodingMiddleware = (opts = {}) => {
 			return;
 		}
 
-		let contentEncodingStream = contentEncodingStreams[preferredEncoding](
-			options[preferredEncoding],
-		);
+		// Resolve encoding choice before creating any stream
 		let contentEncoding = preferredEncoding;
 		for (const encoding of options.overridePreferredEncoding) {
 			if (!preferredEncodings.includes(encoding)) continue;
-			contentEncodingStream = contentEncodingStreams[encoding](
-				options[encoding],
-			);
 			contentEncoding = encoding;
 			break;
 		}
 
 		// Support streamifyResponse
 		if (isNodeStream || isWebStream) {
+			const contentEncodingStream = contentEncodingStreams[contentEncoding](
+				options[contentEncoding],
+			);
 			request.response.headers["Content-Encoding"] = contentEncoding;
 			if (isNodeStream) {
 				request.response.body = request.response.body.pipe(
@@ -95,15 +104,12 @@ const httpContentEncodingMiddleware = (opts = {}) => {
 			addHeaderPart(response, "Vary", "Accept-Encoding");
 			return;
 		}
-		// isString
-		const stream = Readable.from(response.body).pipe(contentEncodingStream);
-
-		const chunks = [];
-		for await (const chunk of stream) {
-			chunks.push(chunk);
-		}
-
-		const body = Buffer.concat(chunks).toString("base64");
+		// isString/isBuffer — use sync compression (avoids stream overhead)
+		const inputBuffer = Buffer.isBuffer(response.body)
+			? response.body
+			: Buffer.from(response.body);
+		const compressed = contentEncodingSync[contentEncoding](inputBuffer);
+		const body = compressed.toString("base64");
 
 		// Only apply encoding if it's smaller
 		if (body.length < response.body.length) {

packages/rds-signer/index.js

@@ -23,9 +23,10 @@ const defaults = {
 const rdsSignerMiddleware = (opts = {}) => {
 	const options = { ...defaults, ...opts };
 
+	const fetchDataKeys = Object.keys(options.fetchData);
 	const fetchRequest = (request, cachedValues = {}) => {
 		const values = {};
-		for (const internalKey of Object.keys(options.fetchData)) {
+		for (const internalKey of fetchDataKeys) {
 			if (cachedValues[internalKey]) continue;
 
 			const client = new options.AwsClient({
@@ -64,7 +65,7 @@ const rdsSignerMiddleware = (opts = {}) => {
 		Object.assign(request.internal, value);
 
 		if (options.setToContext) {
-			const data = await getInternal(Object.keys(options.fetchData), request);
+			const data = await getInternal(fetchDataKeys, request);
 			Object.assign(request.context, data);
 		}
 	};

packages/s3/index.js

@@ -31,9 +31,10 @@ const s3Middleware = (opts = {}) => {
 		...defaults,
 		...opts,
 	};
+	const fetchDataKeys = Object.keys(options.fetchData);
 	const fetchRequest = (request, cachedValues = {}) => {
 		const values = {};
-		for (const internalKey of Object.keys(options.fetchData)) {
+		for (const internalKey of fetchDataKeys) {
 			if (cachedValues[internalKey]) continue;
 			const command = new GetObjectCommand(options.fetchData[internalKey]);
 			values[internalKey] = client
@@ -67,7 +68,7 @@ const s3Middleware = (opts = {}) => {
 		const { value } = processCache(options, fetchRequest, request);
 		Object.assign(request.internal, value);
 		if (options.setToContext) {
-			const data = await getInternal(Object.keys(options.fetchData), request);
+			const data = await getInternal(fetchDataKeys, request);
 			Object.assign(request.context, data);
 		}
 	};

packages/secrets-manager/index.js

@@ -38,10 +38,11 @@ const secretsManagerMiddleware = (opts = {}) => {
 		cacheKeyExpiry: { ...defaults.cacheKeyExpiry, ...opts.cacheKeyExpiry },
 	};
 
+	const fetchDataKeys = Object.keys(options.fetchData);
 	const fetchRequest = (request, cachedValues = {}) => {
 		const values = {};
 
-		for (const internalKey of Object.keys(options.fetchData)) {
+		for (const internalKey of fetchDataKeys) {
 			if (cachedValues[internalKey]) continue;
 
 			const fetchRotation =
@@ -115,7 +116,7 @@ const secretsManagerMiddleware = (opts = {}) => {
 		Object.assign(request.internal, value);
 
 		if (options.setToContext) {
-			const data = await getInternal(Object.keys(options.fetchData), request);
+			const data = await getInternal(fetchDataKeys, request);
 			Object.assign(request.context, data);
 		}
 	};

packages/service-discovery/index.js

@@ -31,10 +31,11 @@ const defaults = {
 const serviceDiscoveryMiddleware = (opts = {}) => {
 	const options = { ...defaults, ...opts };
 
+	const fetchDataKeys = Object.keys(options.fetchData);
 	const fetchRequest = (request, cachedValues = {}) => {
 		const values = {};
 
-		for (const internalKey of Object.keys(options.fetchData)) {
+		for (const internalKey of fetchDataKeys) {
 			if (cachedValues[internalKey]) continue;
 
 			const command = new DiscoverInstancesCommand(
@@ -71,7 +72,7 @@ const serviceDiscoveryMiddleware = (opts = {}) => {
 		Object.assign(request.internal, value);
 
 		if (options.setToContext) {
-			const data = await getInternal(Object.keys(options.fetchData), request);
+			const data = await getInternal(fetchDataKeys, request);
 			Object.assign(request.context, data);
 		}
 	};

packages/ssm/index.js

@@ -35,11 +35,12 @@ const defaults = {
 const ssmMiddleware = (opts = {}) => {
 	const options = { ...defaults, ...opts };
 
+	const fetchDataKeys = Object.keys(options.fetchData);
+	const fetchDataValues = Object.values(options.fetchData);
 	const fetchRequest = (request, cachedValues) => {
-		return {
-			...fetchSingleRequest(request, cachedValues),
-			...fetchByPathRequest(request, cachedValues),
-		};
+		const single = fetchSingleRequest(request, cachedValues);
+		const path = fetchByPathRequest(request, cachedValues);
+		return Object.assign(single, path);
 	};
 
 	const fetchSingleRequest = (request, cachedValues = {}) => {
@@ -48,8 +49,8 @@ const ssmMiddleware = (opts = {}) => {
 		const batchKeys = new Map();
 		const namedKeys = [];
 
-		const internalKeys = Object.keys(options.fetchData);
-		const fetchKeys = Object.values(options.fetchData);
+		const internalKeys = fetchDataKeys;
+		const fetchKeys = fetchDataValues;
 		for (const internalKey of internalKeys) {
 			if (cachedValues[internalKey]) continue;
 			if (options.fetchData[internalKey].endsWith("/")) continue; // Skip path passed in
@@ -124,7 +125,7 @@ const ssmMiddleware = (opts = {}) => {
 
 	const fetchByPathRequest = (request, cachedValues = {}) => {
 		const values = {};
-		for (const internalKey of Object.keys(options.fetchData)) {
+		for (const internalKey of fetchDataKeys) {
 			if (cachedValues[internalKey]) continue;
 			const fetchKey = options.fetchData[internalKey];
 			if (!fetchKey.endsWith("/")) continue; // Skip not path passed in
@@ -182,7 +183,7 @@ const ssmMiddleware = (opts = {}) => {
 		Object.assign(request.internal, value);
 
 		if (options.setToContext) {
-			const data = await getInternal(Object.keys(options.fetchData), request);
+			const data = await getInternal(fetchDataKeys, request);
 			Object.assign(request.context, data);
 		}
 	};