Skip to content

refactor: hard code moves to EVENT_MOVEMENTS constants on key events #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eideard-hm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: hard code moves to EVENT_MOVEMENTS constants on key events #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion consts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ export const BOARD_HEIGHT = 30
export const EVENT_MOVEMENTS = {
LEFT: 'ArrowLeft',
DOWN: 'ArrowDown',
RIGHT: 'ArrowRight'
RIGHT: 'ArrowRight',
UP: 'ArrowUp'
}

export const PIECES = [
Expand Down
2 changes: 1 addition & 1 deletion main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ document.addEventListener('keydown', event => {
}
}

if (event.key === 'ArrowUp') {
if (event.key === EVENT_MOVEMENTS.UP) {
const rotated = []

// ESTO ES LO MÁS COMPLICADO DE LEJOS
Expand Down