fix base fee byte order#258
Open
BitWonka wants to merge 10 commits into
Open
Conversation
Fix Lighthouse v8.1.0 SSE race condition and reward calculation bugs
fix: historical deadlock, attestation flag, concurrent map race, orphan duties
fix: propagate block changes to dependent epochs after reorg + v3.8.0
Fix RoutineBook.Acquire deadlock causing missing block rewards
fix: transaction value uint64 overflow and Float32 precision loss
Fix ProcessSlashings accumulation + ManualReward race condition + block rewards validation
fix: prevent Wait() deadlocks, remove dead relays, add relay circuit breaker
fix(relay): remove securerpc and wenmerge mainnet relays
Collaborator
|
Hey @BitWonka, thanks for opening this PR! We'll review it on our end and follow up shortly. 🙌 |
Collaborator
Author
|
@Zyra-V21 updated, worth considering making dev the default branch so forks would inherit it and PRs would target dev automatically |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Bellatrix and Capella blocks store
BaseFeePerGasas a 32-byte SSZ field in little-endian format. The current code reads the first 8 bytes usingbinary.BigEndian.Uint64(), which interprets them in the wrong byte order, producing a massively inflated base fee value (~11.8 ETH per gas instead of ~13 Gwei).This causes every transaction in Bellatrix/Capella blocks to be skipped in the priority fee calculation (
gasPrice < baseFeePerGasis always true), resulting inf_reward_feesandf_burnt_feesbeing written as 0 for all blocks from the merge (slot 4,700,013) through the Deneb upgrade (slot 8,626,175).Related links:
https://github.com/attestantio/go-eth2-client/blob/master/spec/bellatrix/executionpayload.go#L61
Description
Change
binary.BigEndian.Uint64()tobinary.LittleEndian.Uint64()for both Bellatrix and CapellaBaseFeePerGasparsing inpkg/spec/block.go. This matches how SSZ encodes integers and aligns with theUint64()behavior used by Deneb/Electra/Fulu.Tasks
BaseFeePerGasbyte orderBaseFeePerGasbyte orderProof of Success
Slot 4700853 has a base fee of ~11.9 Gwei (
11913161380Wei) per the beacon API.Before fix, goteth reads this as
11847304610421145600(~11.8 ETH) due to wrong byte order. Since every transaction's gas price is below this inflated value, all are skipped andf_reward_fees/f_burnt_feesare persisted as 0.After fix, the base fee reads correctly and priority fees calculate as expected.