Skip to content

Add applet prolific responder#1

Draft
hamzace wants to merge 1 commit into
devfrom
add-applet-prolific-responder
Draft

Add applet prolific responder#1
hamzace wants to merge 1 commit into
devfrom
add-applet-prolific-responder

Conversation

@hamzace
Copy link
Copy Markdown

@hamzace hamzace commented Jan 24, 2025

  • Tests for the changes have been added
  • Related documentation has been added / updated
  • OSS packages added to MindLogger open source credit page

📝 Description

🔗 Jira Ticket M2-#

Changes include:

  • [Thing]
  • [Other thing]
  • [More things]

📸 Screenshots

Before (Optional) After

🪤 Peer Testing

✏️ Notes

Comment thread .eslintrc.js
pattern: '@(~app|~shared|~features|~pages|~entities)/**',
group: 'internal',
},
{
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use absolute import aliases instead

options?: Options<TData>,
) => {
return useBaseQuery(
['prolificCompletionCode'],
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

options?: Options<TData>,
) => {
return useBaseQuery(
['prolificIntegrationEnabled'],
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import type { NavigateOptions } from 'react-router/dist/lib/context';

import { useUpdateProlificParams } from './useSaveProlificParams';
import { useProlificCompletionCodeQuery } from '../../api/integrations/useProlificCompletionCodeQuery';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~

completionCodes: ProlificCompletionCode[];
};

function getProlificService() {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=>


function getProlificService() {
return {
isProlificIntergrationEnabled(appletId?: string) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=>

`/integrations/prolific/applet/${appletId}`,
);
},
getStudyCompletionCodes(appletId: string, studyId: string) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=>

export type BaseError = {
message?: string;
response: { data: { result: Array<Result> } };
response: { data: { result?: Array<Result> } };
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Comment thread src/widgets/ActivityGroups/ui/index.tsx Outdated
type Props = PublicAppletDetails | PrivateAppletDetails;

type ProlificState = {
error: boolean;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isError

@hamzace hamzace requested a review from elierotenberg January 29, 2025 19:00
Comment thread .eslintrc.js
group: 'internal',
},
{
pattern: '~/lib/**',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merger with rule above

@hamzace hamzace force-pushed the add-applet-prolific-responder branch from ed25c4e to 8774cda Compare January 30, 2025 16:17
@hamzace hamzace force-pushed the add-applet-prolific-responder branch from 8774cda to 9bbc54a Compare January 30, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants