Expose metrics #6
Conversation
There was a problem hiding this comment.
You may consider moving the creation of data-oriented properties on this. (this.x and this.y) into componentWillMount, and the creation of DOM nodes into either componentWillMount (runs before first render) or componentDidMount (runs after first render). getInitialState should generally be a pure function that only returns the initial data for this.state.
|
@genehallman Okay, those are my high-level notes. Nice job on this, I'd never guess you learned React in a weekend! We can chat in more detail about some more advanced things soon. |
|
@genehallman I've been trying to get to you, I know this isnt the right place to ask but I couldnt find an email address for you anywhere, I made some changes to pykurento to make it support version 6 of kms but I got everything working except the composites, is it possible for you to show me a demo code of how to use a composite (and hub for it)? |
|
@BinaryMuse Thanks for the review, really helpful. @CheyenneForbes I replied to your issue in the pykurento repo. |
@genehallman I'm opening this PR purely for code review purposes. I've changed the base to where you started working on the React portion of the UI. Comments will largely be inline.