Skip to content
This repository was archived by the owner on Feb 13, 2026. It is now read-only.

crypto: add helper functions for unsealing object keys#6609

Merged
kannappanr merged 1 commit intominio:masterfrom
aead:object-key-helper
Oct 13, 2018
Merged

crypto: add helper functions for unsealing object keys#6609
kannappanr merged 1 commit intominio:masterfrom
aead:object-key-helper

Conversation

@aead
Copy link
Member

@aead aead commented Oct 10, 2018

Description

This commit adds 2 helper functions for SSE-C and SSE-S3
to simplify object key unsealing in server code.

Motivation and Context

See #6600

Regression

no

How Has This Been Tested?

unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.
  • I have added/updated functional tests in mint. (If yes, add mint PR # here: )
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #6609 into master will increase coverage by 0.01%.
The diff coverage is 92%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6609      +/-   ##
=========================================
+ Coverage   55.78%   55.8%   +0.01%     
=========================================
  Files         250     250              
  Lines       37742   37767      +25     
=========================================
+ Hits        21054   21075      +21     
- Misses      14747   14749       +2     
- Partials     1941    1943       +2
Impacted Files Coverage Δ
cmd/crypto/sse.go 59.52% <92%> (+47.75%) ⬆️
cmd/xl-v1-common.go 82.6% <0%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f09e7ca...9a3e07d. Read the comment docs.

kannappanr
kannappanr previously approved these changes Oct 11, 2018
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kannappanr
kannappanr previously approved these changes Oct 11, 2018
@kannappanr
Copy link
Contributor

@aead Travis failed

@aead aead mentioned this pull request Oct 11, 2018
9 tasks
This commit adds 2 helper functions for SSE-C and SSE-S3
to simplify object key unsealing in server code.

See minio#6600
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@donatello donatello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 28e25ea into minio:master Oct 13, 2018
@aead aead deleted the object-key-helper branch September 19, 2019 20:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants