Export-ignore test files#691
Conversation
|
The driver repos are using Mink as dependency and are running |
|
Sorry, I don't really know the internals of Mink, so perhaps there are better solutions. I would just like to suggest to package only what is needed. If other packages are relying on the driver-testsuite for their tests, wouldn't it be better to create a seperate repository for the driver-testsuite? You can require-dev that package from here and the other drivers. |
|
But yeah, I don't know how many drivers there are, and if they're all maintained by you, but adding --prefer-source to the Travis script would be a simple solution also :) |
|
These are the all drivers maintained by Mink: https://github.com/minkphp?utf8=%E2%9C%93&query=Driver |
| @@ -0,0 +1,8 @@ | |||
| /driver-testsuite export-ignore | |||
There was a problem hiding this comment.
This folder is necessary when installing Mink as a dependency of a driver, as it is a testsuite meant to be used by drivers
There was a problem hiding this comment.
See comment here: #691 (comment)
If other packages are relying on the driver-testsuite for their tests, wouldn't it be better to create a seperate repository for the driver-testsuite? You can require-dev that package from here and the other drivers.
There was a problem hiding this comment.
Well, the issue with this setup would be versionning for changes in Mink. But yeah, this is something I already thought about.
There was a problem hiding this comment.
Yes and the alternative is using --prefer-source in the other drivers travis setup.
There was a problem hiding this comment.
not only on Travis but for anyone working on drivers, making contributing harder. And forcing to use source installs is also bad as it means that all other deps of the driver will also be installed from source, forbidding to use the cache (making builds slower)
There was a problem hiding this comment.
Well, the builds mostly aren't cached anyways because of API limits (they're cloning as fallback): https://travis-ci.org/minkphp/MinkGoutteDriver/jobs/98220899
But agreed, it would make it harder for them. But it seems a bit odd to include a development dependancy for everyone. As a seperate repository, it wouldn't have to be included for the rest of the users (the 99%)
There was a problem hiding this comment.
Well, the cache contains older archives. At one point, we were lucky to avoid hitting the rate limit.
I totally agree that a separate repo would be better for this particular reason. But it is not done yet, so excluding it from the archive today is wrong.
There was a problem hiding this comment.
I've removed that line.
| @@ -0,0 +1,7 @@ | |||
| /tests export-ignore | |||
There was a problem hiding this comment.
Isn't this folder somehow used, when running driver test suite as well?
There was a problem hiding this comment.
Is that possible, when it's only autoloaded on dev?
There was a problem hiding this comment.
I've double checked with one of the drivers (see https://github.com/minkphp/MinkSelenium2Driver/blob/master/phpunit.xml.dist#L7) and it seems, that only driver-testsuite folder is included in PHPUnit. So this should work theoretically.
There was a problem hiding this comment.
I confirm that the driver testsuite does not need this at all.
|
OK, merging this to make the archive smaller. The case of the driver-testsuite will be handled separately |
3 participants
This will exclude the tests en driver-testsuite (+ some other files) from the archives, downloaded with Composer and directly via Github. As this code is not used in production, it doesn't have to be included.
People can still use --prefer-source to get the full archive with tests etc. Should also prevent code from being run when the vendor folder is not properly protected (#677)