Skip to content

Expand the contributing guide for external contributors#2097

Open
oliv3rdrt wants to merge 1 commit into
mintlayer:masterfrom
oliv3rdrt:docs/673-external-contributor-guide
Open

Expand the contributing guide for external contributors#2097
oliv3rdrt wants to merge 1 commit into
mintlayer:masterfrom
oliv3rdrt:docs/673-external-contributor-guide

Conversation

@oliv3rdrt

Copy link
Copy Markdown

While going through the repository as a new external contributor, I noticed the external contributor section of CONTRIBUTING.md explains forking and branching but does not cover how to actually build the project, run the tests, or run the checks that CI enforces. This adds a few short subsections to fill that gap:

  • Setting up your environment: cloning your fork, cargo build, and the Linux build dependencies (build-essential, libdbus-1-dev, libusb-1.0-0-dev), plus a note that the checks script needs Python.
  • Running the tests: the cargo test --release --workspace command that CI uses, and a note that the heavier tests are ignored by default.
  • Before you open a pull request: running ./do_checks.sh to reproduce the CI static checks locally (fmt, clippy, cargo-deny, cargo-vet), including installing cargo-deny and cargo-vet.

Everything is based on the existing CI workflows and do_checks.sh, so it should match what already runs. Addresses #673.

The external contributor section explained the fork and branch workflow but
did not say how to actually build, test, or run the checks that CI enforces.
Add short subsections covering environment setup and the Linux build
dependencies, running the test suite, and running do_checks.sh before opening
a pull request so contributors can reproduce the CI static checks locally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant