Skip to content

Show possible values and defaults in the node help#2099

Open
oliv3rdrt wants to merge 1 commit into
mintlayer:masterfrom
oliv3rdrt:fix/548-node-help-default-values
Open

Show possible values and defaults in the node help#2099
oliv3rdrt wants to merge 1 commit into
mintlayer:masterfrom
oliv3rdrt:fix/548-node-help-default-values

Conversation

@oliv3rdrt

Copy link
Copy Markdown

The node help does not show which values the constrained options accept or what they default to, so you currently have to read the source to find out (#548).

This makes a start on it by documenting the following in the help text:

  • --storage-backend: possible values lmdb, inmemory, defaults to lmdb.
  • --node-type: possible values full-node, blocks-only-node, defaults to full-node.
  • --rpc-bind-address: defaults to 127.0.0.1 with the chain's default RPC port.
  • --rpc-enabled: defaults to true.

I focused on the options where the default has a single clear source in the code. Many of the numeric run options get their defaults deeper in the individual subsystems, so I left those out for now rather than risk documenting a value that might drift out of date. I am happy to extend this to more options if that is a welcome direction.

Verified with node-daemon mainnet --help. Addresses part of #548.

The node help did not show which values the constrained options accept or
what they default to, so users had to read the source to find out. Document
the possible values and defaults for --storage-backend and --node-type, and
the defaults for --rpc-bind-address and --rpc-enabled, in their help text.
Verified with 'node-daemon mainnet --help'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant