fix(packages/components/src): MDX indentation#236
Open
code-qtzl wants to merge 2 commits intomintlify:mainfrom
Open
fix(packages/components/src): MDX indentation#236code-qtzl wants to merge 2 commits intomintlify:mainfrom
code-qtzl wants to merge 2 commits intomintlify:mainfrom
Conversation
Co-authored-by: Copilot <copilot@github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 212818e. Configure here.
ba3d064 to
728aecf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Issue: #226
Summary
When CodeBlock is used inside MDX/JSX with template literals, the code content inherits the surrounding JSX indentation, causing it to render with extra leading whitespace. This fix adds a dedentCode utility that detects the minimum indentation across all non-empty lines (after the first) and strips it uniformly, so the rendered code aligns correctly regardless of nesting depth.
Two Storybook stories (MDXIndents, MDXIndentsDeeplyNested) are added to cover typical and deeply-nested JSX indentation scenarios.
MDXIndents
MDXIndentsDeeplyNested
Note
Medium Risk
Changes how
CodeBlock/CodeGroupderive the raw code string (used for rendering and copy), which could unintentionally alter leading whitespace in some code samples beyond the MDX template-literal cases.Overview
Fixes extra leading whitespace when
CodeBlockcontent is provided via indented MDX/JSX template literals by adding adedentCodestep togetCodeString.Updates
CodeBlockandCodeGroupto usegetCodeString(instead ofgetNodeText) for copy-to-clipboard text extraction, and adds two Storybook stories (MDXIndents,MDXIndentsDeeplyNested) to cover nested indentation scenarios.Reviewed by Cursor Bugbot for commit 728aecf. Bugbot is set up for automated code reviews on this repo. Configure here.