ci: label-driven AI re-review (v1.2.9)#368
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
AI Automated Review
Full PR review.
Analysis engine: review@https://litellm.jory.dev/v1 (openai) — fast route
Recommendation
Approved. This PR simplifies the AI PR review trigger by moving from a comment-based command (/ai-review) to a label-based trigger (ai-review). This is a cleaner UX and improves security by leveraging GitHub's native label permissions (write/triage) for authorization.
Change-by-change findings
.github/workflows/ai-pr-review.yaml:- Added
labeledto thepull_requestevent types to support the new trigger. - Removed the
issue_commentevent type and the associated logic for parsing comment bodies. - Removed the
Check out re-review command gateandAuthorize re-review commandsteps, which were used to validate the/ai-reviewcomment. - Removed the
Acknowledge authorized re-reviewstep (which added a rocket reaction to the comment). - Updated the
Review PR with reusable AI reviewerstep to use the newmisospace/pr-reviewer-action@v1.2.9(pinned to SHA4126a2701a5e9adcf7c48ac6eb678e2e3a2bb2a0) and removed theforce_reviewparameter as the trigger is now event-driven via labels. - Updated concurrency group to use
github.refas a fallback to ensure correct grouping when the event is not a standardpull_requestevent.
- Added
Standards Compliance
- Security: The authorization mechanism is improved. Instead of parsing text in a comment, it now relies on GitHub's permission model for labels (only users with
writeortriagepermissions can trigger a re-review by adding the label). - CI/CD: The PR updates the pinned version of the
pr-reviewer-actiontov1.2.9, which is consistent with the PR's stated purpose. - Code Standards: The removal of complex shell scripts and manual comment parsing reduces the surface area for potential bugs in the CI pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the
ai-reviewlabel to a PR now forces a re-review: pr-reviewer-action v1.2.9 handles thelabeledevent natively (skipping unrelated labels) and removes the label after publishing, so re-adding it re-triggers. Labeling is restricted to write/triage, so the trigger is self-authorizing.This replaces the
/ai-reviewcomment-command wiring, which is removed along with its authorization gate; the action pin is bumped to v1.2.9.🤖 Generated with Claude Code