Skip to content

test(pr-followup): add PrFixType assertions to ingestion tests #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joryirving merged 2 commits into from
Jun 16, 2026
Merged

test(pr-followup): add PrFixType assertions to ingestion tests #380

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
815fbea
test(pr-followup): add PrFixType assertions to ingestion tests
Jun 16, 2026
b3245c6
docs(pr-followup): clarify PrFixType implementation is on main
Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/lib/pr-followup-ingestion.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ describe("ingestCommentEvent", () => {

expect(client.items).toHaveLength(1);
expect(client.items[0].lane).toBe("NORMAL");
expect(client.items[0].type).toBe("REVIEW_FEEDBACK");
expect(client.items[0].reason).toContain("actionable feedback");
});

Expand All @@ -187,6 +188,7 @@ describe("ingestCommentEvent", () => {

expect(client.items).toHaveLength(1);
expect(client.items[0].lane).toBe("NEEDS_HUMAN");
expect(client.items[0].type).toBe("REVIEW_FEEDBACK");
expect(client.items[0].status).toBe("BLOCKED");
});

Expand Down Expand Up @@ -233,6 +235,7 @@ describe("ingestReviewEvent", () => {

expect(client.items).toHaveLength(1);
expect(client.items[0].lane).toBe("NORMAL");
expect(client.items[0].type).toBe("REVIEW_FEEDBACK");
});

it("skips APPROVED reviews", async () => {
Expand Down Expand Up @@ -342,6 +345,7 @@ describe("ingestCheckRunEvent", () => {

expect(client.items).toHaveLength(1);
expect(client.items[0].lane).toBe("NORMAL");
expect(client.items[0].type).toBe("CI_FAILURE");
});

it("enqueues cancelled/timed_out checks", async () => {
Expand All @@ -361,6 +365,7 @@ describe("ingestCheckRunEvent", () => {
});

expect(client.items).toHaveLength(1);
expect(client.items[0].type).toBe("CI_FAILURE");
});

it("skips passing checks", async () => {
Expand Down Expand Up @@ -405,6 +410,7 @@ describe("ingestMergeStateEvent", () => {

expect(client.items).toHaveLength(1);
expect(client.items[0].lane).toBe("NORMAL");
expect(client.items[0].type).toBe("OTHER");
});

it("skips clean merge state", async () => {
Expand Down Expand Up @@ -463,6 +469,25 @@ describe("ingestMergeStateEvent", () => {
expect(client.items).toHaveLength(0);
});

it("populates MERGE_CONFLICT type for DIRTY merge state", async () => {
process.env.PR_FOLLOWUP_BOT_IDENTITIES = "itsmiso-ai";
const client = makeClient();

await ingestMergeStateEvent(client, {
repoFullName: "misospace/dispatch",
prNumber: 42,
branch: "fix/test",
url: "https://github.com/misospace/dispatch/pull/42",
title: "Fix test issue",
author: "itsmiso-ai",
mergeStateStatus: "dirty",
});

expect(client.items).toHaveLength(1);
expect(client.items[0].type).toBe("MERGE_CONFLICT");
});


afterEach(() => {
delete process.env.PR_FOLLOWUP_BOT_IDENTITIES;
});
Expand Down