fix: warn when MCP agent name is unset

[itsmiso-ai]

Closes #421

[its-saffron]

AI Automated Review

Full PR review.

Analysis engine: MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic) — escalated (fast_request_changes,fast_low_confidence)

Review: PR PR 436 — fix: warn when MCP agent name is unset

Recommendation: Request Changes

Critical Issue: Empty PR

This PR claims to close issue PR 421 ("Add a startup-time warning in the MCP server entrypoint if DISPATCH_AGENT_NAME is unset"), but the PR diff shows:

• Changed files: 0
• Additions: 0
• Deletions: 0

This PR contains no code changes whatsoever. It cannot possibly satisfy the linked issue's acceptance criteria without implementing the startup warning.

Verification Against Issue PR 421

Issue PR 421 explicitly requires:

• Adding a startup-time warning in src/mcp/server.ts when DISPATCH_AGENT_NAME is unset
• Mirroring the DISPATCH_AUTH_MODE=disabled warning pattern from docker-entrypoint.sh

The repository history shows commit 5bbe73f ("fix: warn when MCP agent name is unset at startup") exists on this branch, and git grep confirms the implementation exists in the source tree:

• src/mcp/server.ts:362: * Logs a startup warning when DISPATCH_AGENT_NAME is unset.
• src/mcp/server.test.ts:753: it("emits warning when DISPATCH_AGENT_NAME is unset", () => {

However, these changes are not reflected in the PR diff. The PR as submitted is empty.

Required Actions

1. Push the actual implementation commit(s) to the PR branch so they appear in the diff
2. Verify the diff shows changes to src/mcp/server.ts that add the startup warning
3. Ensure test coverage for the warning behavior is included (the test at server.test.ts:753 should pass)

Standards Compliance

Cannot assess — there are no changed files to review against repository conventions.

Linked Issue Fit

Not satisfied. Issue PR 421 requires implementation work. An empty PR does not fulfill the issue's acceptance criteria.

Evidence Provider Findings

N/A — no evidence providers configured.

Tool Harness Findings

N/A — tool harness results do not relate to this PR's content.

Unknowns

• The implementation may exist in a commit not yet pushed to the PR branch
• The diff may have been truncated or failed to load