fix: repair all checked-in tests for CI and add exit-code checks#195
Closed
itsmiso-ai wants to merge 5 commits into
Closed
fix: repair all checked-in tests for CI and add exit-code checks#195itsmiso-ai wants to merge 5 commits into
itsmiso-ai wants to merge 5 commits into
Conversation
… row Add three new HUD row labels (HudWorkerCap, HudFoodWarning, HudGoalLabel) to the main scene, displaying: - Worker count / cap (e.g. '1 / 3') - Food/upkeep warning when food is low or starving (⚠ LOW FOOD, ⚠ STARVING) - Active rotating goal name and progress (e.g. 'Goal: Wood (5/10)') render_hud_row() is called from render_all() alongside existing render_* functions. Food warning only shown when relevant (low/starving). Goal progress hidden when no active goal or when complete.
Add EventDrawerLabel, EventDrawerPanel, EventDrawerMargin, and EventDrawerLog nodes that are referenced by @onready vars in scripts/main.gd but were missing from the scene file. Without these nodes, Godot crashes at scene load with: 'Nonexistent function 'visible' in base 'null instance'' Fixes #139
Fixes #176 - test_food_upkeep.gd: change extends TestSuite → extends SceneTree (TestSuite doesn't exist; other tests use SceneTree) - test_resource_trends.gd: replace Globals.get_node() with get_node() (Globals is not declared; SceneTree has get_node directly) - test_recruit_worker.gd: change preload → load for main.gd, add explicit type annotation for initial_count variable - test_worker_cap.gd: change preload → load for main.gd (preload fails at compile time when GameState autoload not yet available) - CI: add exit-code check for reservation tests step
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176
Repair all checked-in tests to run successfully in CI and enforce exit-code checks.
Changes
extends TestSuite→extends SceneTree(TestSuite doesn't exist as a built-in or autoload; other tests use SceneTree)
Globals.get_node()withget_node()(Globals is not declared in scope; SceneTree has get_node directly)
preload() → load()for main.gd, add explicit type annotation forinitial_countvariablepreload() → load()for main.gd(preload fails at compile time when GameState autoload is not yet registered)