fix(ci): add exit-code check for reservation tests step#200
Merged
Conversation
The reservation tests step in CI was missing exit-code enforcement, meaning test failures would silently pass. Add proper exit-code checking consistent with all other test steps (script, E2E, layout). Refs #176
![its-saffron[bot]](https://avatars.githubusercontent.com/in/3901073?s=60&v=4){kind=small}
There was a problem hiding this comment.
AI Automated Review
Full PR review.
Analysis engine: review@https://litellm.jory.dev/v1 (openai)
Recommendation
Approved. This PR correctly addresses the issue by ensuring that failures in the reservation tests are captured and cause the CI job to fail, preventing silent passes on test failures.
Change-by-change findings
- .github/workflows/test.yml: Added logic to capture the exit code (
RES_EXIT=$?) of the reservation tests command. It now checks if the exit code is non-zero, prints a GitHub error annotation if it fails, and exits the job with code 1. This aligns the reservation tests step with the existing behavior of the script, E2E, and layout regression test steps.
Linked Issue Fit
- Issue PR 176: The PR directly satisfies the requirement to "add exit-code checks for reservation tests" as identified in the audit findings. It resolves the specific problem where the reservation CI step was printing logs but not failing the job on non-zero exit codes.
Standards Compliance
- The implementation follows the existing pattern in
.github/workflows/test.ymlfor handling test failures (using::error::annotations andexit 1), maintaining consistency across the CI pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176
Add exit-code enforcement to the reservation tests CI step, consistent with all other test steps (script, E2E, layout).
Previously the reservation tests step ran the tests but did not fail the CI job on non-zero exit — a silent pass on test failure. This fix captures the exit code and fails the job if tests do not pass.