Use Newark Application class variables directly#2
Open
jackxxu wants to merge 1 commit intomje113:masterfrom
Open
Use Newark Application class variables directly#2jackxxu wants to merge 1 commit intomje113:masterfrom
jackxxu wants to merge 1 commit intomje113:masterfrom
Conversation
## Use Newark Application class variables directly Currently, in a Newark app, three class variables `routes`, `before_hooks`, and `after_hooks` are used to store system-level variables. This PR is intended to leverage these class instance variables directly instead of creating a copy of these variables upon each request. The clear benefit is to presumably make it more efficient and smaller memory footprint.
Contributor
Author
|
now I look at it, I don't think this PR actually saves much RAM footprint at all, but I do think it can be more efficient in executing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Newark Application class variables directly
Currently, in a Newark app, three class variables
routes,before_hooks, andafter_hooksare used to store system-level variables. This PR is intended to leverage these class instance variables directly instead of creating a copy of these variables upon each request. The clear benefit is to presumably make it more efficient and smaller memory footprint.