tech(ci): harden github actions workflows#97
Merged
Conversation
- Add explicit `permissions: contents: read` to ci.yml and build.yml so the GITHUB_TOKEN blast radius on pull_request runs is minimal regardless of repo defaults. - SHA-pin `softprops/action-gh-release` (the only third-party action that runs in a job with secrets) to v3.0.0 commit b430933, so an upstream tag-move can't silently flow into the release pipeline. Dependabot/Renovate can still bump it via the trailing version comment. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defense-in-depth hardening of the GitHub Actions workflows. No
pull_request_targetor other RCE-class issues were found — this is preventative tightening of the two next-most-material weaknesses: missing explicitGITHUB_TOKENscope on the PR-triggered workflows, and a mutable-tag-pinned third-party action in the only job that runs with secrets.Changes
permissions: contents: readto ci.yml and build.yml so theGITHUB_TOKENcap onpull_requestruns is minimal regardless of repo-level defaultssoftprops/action-gh-releasein build-and-publish.yml (@v2→@b4309332981a82ec1c5618f44dd2e27cc8bfbfda # v3.0.0); this is the only third-party action that runs in a job with secrets (MACOS_CERTIFICATE,APPLE_ID_PASSWORD, etc.), so an upstream tag-move can't silently flow into the release pipeline. Trailing version comment keeps Dependabot/Renovate bumps visibleType of change
Checklist
flutter analyzepasses with no issues — N/A, workflow YAML onlydart format lib/ test/applied — N/A, no Dart changesflutter testpasses — N/A, no Dart changesbuild_runnerwas re-run and generated files are committed — N/A