Skip to content

Enable an https lr server#21

Merged
mklabs merged 1 commit into
mklabs:masterfrom
joeybaker:patch-1
Sep 24, 2013
Merged

Enable an https lr server#21
mklabs merged 1 commit into
mklabs:masterfrom
joeybaker:patch-1

Conversation

@joeybaker

Copy link
Copy Markdown
Contributor

By passing the contents of cert files, we can enable an https version of the lr server which is super handy for debugging https.

By passing the contents of cert files, we can enable an https version of the lr server which is super handy for debugging https.
@leog

leog commented Sep 16, 2013

Copy link
Copy Markdown

Waiting for this merge!

@joeybaker

Copy link
Copy Markdown
Contributor Author

@mklabs any thoughts on this?

@herebefrogs

Copy link
Copy Markdown

+1!

@mklabs

mklabs commented Sep 24, 2013

Copy link
Copy Markdown
Owner

That looks good, thanks a lot.

mklabs added a commit that referenced this pull request Sep 24, 2013
Enable an https lr server
@mklabs
mklabs merged commit 12c125e into mklabs:master Sep 24, 2013
@mklabs

mklabs commented Sep 24, 2013

Copy link
Copy Markdown
Owner

I'll bump version to 0.0.5 and publish to registry once I get the chance, thanks again.

@joeybaker
joeybaker deleted the patch-1 branch September 24, 2013 15:23
@joeybaker

Copy link
Copy Markdown
Contributor Author

@mklabs cheers sir!

joeybaker added a commit to joeybaker/grunt-contrib-watch that referenced this pull request Nov 3, 2013
@advdv

advdv commented Apr 9, 2014

Copy link
Copy Markdown

Shouldn't the _uri template (livereload.js at line 141: this._uri = "ws://" + this.options.host + ":" + this.options.port + "/livereload";) be changed to secure protocals as well in this case?:
this._uri = "wss://" + this.options.host + ":" + this.options.port + "/livereload";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants