#100 inner scrolling doesnt respect container border width - #184
Closed
CoryDuncan wants to merge 1 commit into
Closed
#100 inner scrolling doesnt respect container border width#184CoryDuncan wants to merge 1 commit into
CoryDuncan wants to merge 1 commit into
Conversation
Owner
|
Thanks for looking into this one :) Unfortunately your PR breaks the absolutePostioning:false version of the testcase, and also removing tableContainerGap breaks tables where there is stuff above table but within the scrollingContainer. Since you took the time to open this PR, I took some time to create a jsfiddle which show the issues above: This is what the original code does: This is what this PR does: Thanks! |
Author
|
Thanks for the quick review on this. I'll look into it some more based on the test cases you mentioned. |
Author
|
moved to #185 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for test case: http://mkoryak.github.io/floatThead/tests/issue-100/