Skip to content

#100 inner scrolling doesnt respect container border width - #184

Closed
CoryDuncan wants to merge 1 commit into
mkoryak:masterfrom
CoryDuncan:master
Closed

#100 inner scrolling doesnt respect container border width#184
CoryDuncan wants to merge 1 commit into
mkoryak:masterfrom
CoryDuncan:master

Conversation

@CoryDuncan

Copy link
Copy Markdown

@mkoryak

mkoryak commented Apr 8, 2015

Copy link
Copy Markdown
Owner

Thanks for looking into this one :)

Unfortunately your PR breaks the absolutePostioning:false version of the testcase, and also removing tableContainerGap breaks tables where there is stuff above table but within the scrollingContainer. Since you took the time to open this PR, I took some time to create a jsfiddle which show the issues above:

This is what the original code does:
https://jsfiddle.net/2rv7mo29/2/embedded/result/

This is what this PR does:
https://jsfiddle.net/5xcvu0tk/3/embedded/result/

Thanks!

@CoryDuncan

Copy link
Copy Markdown
Author

Thanks for the quick review on this. I'll look into it some more based on the test cases you mentioned.

@CoryDuncan CoryDuncan closed this Apr 8, 2015
@CoryDuncan

Copy link
Copy Markdown
Author

moved to #185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants