[WIP] Add mlx.core.searchsorted #2817
Removes unused headers to satisy clangd
Drops unused header dependencies: - removes transforms.h from the operations module - removes backend/utils.h from primitives
- Loading branch information
commit f8161f38046ae249568ed75646d55d45201e86e3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,6 @@ | |
| #include <sstream> | ||
| #include <stdexcept> | ||
|
|
||
| #include "mlx/fft.h" | ||
|
There was a problem hiding this comment. The removed include for "mlx/backend/common/utils.h" should be verified as unnecessary. Ensure that no functions or utilities from this header are used elsewhere in primitives.cpp before removing it. |
||
| #include "mlx/linalg.h" | ||
| #include "mlx/ops.h" | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removed include for "mlx/transforms.h" may be needed elsewhere in the file. Only remove this include if you've verified that no part of ops.cpp requires declarations from transforms.h. The fact that transforms_impl.h is still included suggests transforms.h might have been providing necessary declarations.