Add asarray to __array_namespace__ #2966
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the asarray function to the mlx.core module, making it available via the Array API namespace. Fixes ml-explore#2945
awni
requested changes
Jan 5, 2026
Member
awni
left a comment
awni
left a comment
There was a problem hiding this comment.
This is an incomplete fix. mx.asarray should be able to handle any input types that the array constructor can. Please update it and add more tests as appropriate.
Use ArrayInitType and create_array() to handle lists, tuples, and nested sequences in addition to scalars and arrays.
Author
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
asarrayfunction tomlx.coremodulexp.asarray()available via the Array API namespaceTest plan
test_array_namespace_asarraytestFixes #2945