Skip to content

vdb_benchmark: adding AISAQ indexing support#230

Merged
FileSystemGuy merged 2 commits into
mlcommons:TF_VDBBenchfrom
ram-sangle:vdb
Feb 12, 2026
Merged

vdb_benchmark: adding AISAQ indexing support#230
FileSystemGuy merged 2 commits into
mlcommons:TF_VDBBenchfrom
ram-sangle:vdb

Conversation

@ram-sangle
Copy link
Copy Markdown
Contributor

  • Updated milvus, etcd and minio versions to support AISAQ as indexing algorithm
  • Added configuration yaml files for AISAQ and DISKANN comparison
  • Added handling for AISAQ indexing parameters
  • README.md update

@ram-sangle ram-sangle requested a review from a team January 27, 2026 06:51
@ram-sangle ram-sangle requested a review from a team as a code owner January 27, 2026 06:51
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 27, 2026

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@ram-sangle ram-sangle changed the base branch from main to TF_VDBBench January 27, 2026 06:53
@ram-sangle
Copy link
Copy Markdown
Contributor Author

recheck

Copy link
Copy Markdown
Contributor

@idevasena idevasena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my end. Everything works.
May be a nit: Since --vector-dim assumes default of 1536, I think we should update README.md for Step 3: Run the benchmark that the cli argument needs to be used when running search phase else it raises MilvusException: vector dimension mismatch.

Updated Run section with --vector-dim parameter usage.
@ram-sangle
Copy link
Copy Markdown
Contributor Author

ram-sangle commented Jan 30, 2026

Thanks @idevasena for trying out the PR. Updated README.md with --vector-dim parameter use.
Working with mlcommons support team to get me added to approved contributors list.

@ram-sangle
Copy link
Copy Markdown
Contributor Author

recheck

@ram-sangle
Copy link
Copy Markdown
Contributor Author

@idevasena / @FileSystemGuy, CLA check issue is resolved.
One more workgroup reviewer need to approve this PR for merge.

@FileSystemGuy FileSystemGuy merged commit f1d6dc1 into mlcommons:TF_VDBBench Feb 12, 2026
1 of 2 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants