Skip to content

[DOC] Hyphenation consistency#9480

Merged
drammock merged 4 commits intomne-tools:mainfrom
alexrockhill:doc_consistency
Jun 17, 2021
Merged

[DOC] Hyphenation consistency#9480
drammock merged 4 commits intomne-tools:mainfrom
alexrockhill:doc_consistency

Conversation

@alexrockhill
Copy link
Contributor

Most tutorials are like so _tut-working-with-ecog but a few used underscores as in _tut_working_with_ecog. This just makes them all consistent the way the majority are.

@alexrockhill
Copy link
Contributor Author

Looks like the build had an out-of-date cache from the other PR but it doesn't look legit.

Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no objection.

@drammock I think you're the best person to approve this :)

thx @alexrockhill

Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no objection.

@drammock I think you're the best person to approve this :)

thx @alexrockhill

@drammock
Copy link
Member

changes look good, but CircleCI is failing on the "working with SEEG data" tutorial.

@alexrockhill
Copy link
Contributor Author

changes look good, but CircleCI is failing on the "working with SEEG data" tutorial.

I think there's issues with the cache so it would probably be easiest if #9478 was merged first and then it was rebased. I think that would fix it.

update version

fixed the transform, the issue was units

added myself as author, probably good for answering questions since I collected the data

fix detrend issue

so many ways to format notes

had to move note

finally fixed the note and fixed in the other ieeg example too

more specific

extra space

fix note in ECoG

Change tutorial formatting to be consistent

remove off-target changes

put back spaces

missed a hyphen
@alexrockhill
Copy link
Contributor Author

Good to merge?

@drammock drammock merged commit fb7cf92 into mne-tools:main Jun 17, 2021
@alexrockhill alexrockhill deleted the doc_consistency branch June 17, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants