[MAINT, MRG] Better transform error that prints coordinate frames#9622
Merged
larsoner merged 1 commit intomne-tools:mainfrom Jul 28, 2021
Merged
[MAINT, MRG] Better transform error that prints coordinate frames#9622larsoner merged 1 commit intomne-tools:mainfrom
larsoner merged 1 commit intomne-tools:mainfrom
Conversation
Contributor
Author
|
All the tests pass, good to go I think |
larsoner
approved these changes
Jul 28, 2021
Comment on lines
66
to
+69
| if cf not in _str_to_frame: | ||
| raise ValueError('Unknown cf %s' % cf) | ||
| raise ValueError( | ||
| f'Unknown coordinate frame {cf}, ' | ||
| 'expected "' + '", "'.join(_str_to_frame.keys()) + '"') |
Member
There was a problem hiding this comment.
Someday we should just use _check_option for this
Member
|
Thanks @alexrockhill ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought it would be helpful to have the allowed coordinate frames for a transform. I also updated to fstring syntax while I was there so that the PR would do a bit more maintenance but that can be reverted if it's not helpful.