Skip to content
This repository was archived by the owner on Dec 31, 2020. It is now read-only.

Add the ability to pass multiple children to Provider#737

Merged
danielkcz merged 1 commit into
mobxjs:masterfrom
vkrol:add-ability-to-pass-multiple-children-to-provider
Jul 31, 2019
Merged

Add the ability to pass multiple children to Provider#737
danielkcz merged 1 commit into
mobxjs:masterfrom
vkrol:add-ability-to-pass-multiple-children-to-provider

Conversation

@vkrol
Copy link
Copy Markdown
Contributor

@vkrol vkrol commented Jul 31, 2019

I think that this is an old restriction when the legacy Context API was used in Provider.

Comment thread src/Provider.js
@danielkcz
Copy link
Copy Markdown
Contributor

I suppose it makes sense to lift that restriction. I just checked if Context.Provider really does allow multiple children and it's true, so there is no reason to limit that here.

@danielkcz danielkcz merged commit cfbe507 into mobxjs:master Jul 31, 2019
@vkrol vkrol deleted the add-ability-to-pass-multiple-children-to-provider branch July 31, 2019 20:15
@vkrol
Copy link
Copy Markdown
Contributor Author

vkrol commented Jul 31, 2019

@FredyC Sorry, I forgot to delete Children import in this file 🤦‍♂ We need to introduce ESLint to the repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants