This repository was archived by the owner on Dec 31, 2020. It is now read-only.
Use same naming scheme and styles in imports in tests#762
Merged
danielkcz merged 1 commit intoAug 21, 2019
Merged
Conversation
danielkcz
suggested changes
Aug 14, 2019
Contributor
danielkcz
left a comment
danielkcz
left a comment
There was a problem hiding this comment.
I wonder if there are some ESLint rules to enforce that. Otherwise, I agree to do it for src as well.
Contributor
Author
I don't know any. |
Contributor
Author
|
@FredyC thank you very much for code reviews and interesting discussions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working with the tests, I constantly encountered different naming and import styles in the tests. I think it's best to use the same naming style for imports. This reduces the cognitive load when working with the existing code and allows you not to think about what style to use when writing a new code.
I also want to use the same style in modules located in the
src directory. If you don't mind, I'll do it in a separate PR.