buildkitd: use asyncremove on overlay#1007
Merged
tiborvass merged 1 commit intomoby:masterfrom May 22, 2019
Merged
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Member
Author
tiborvass
approved these changes
May 15, 2019
Collaborator
tiborvass
left a comment
tiborvass
left a comment
There was a problem hiding this comment.
From looking at containerd code this looks alright, but I'd prefer other eyes given I'm not able to reproduce the issue.
Contributor
|
It does not appear to reconcile #991, I'll post some more logs with this PR to the issue shortly. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #991
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com