docs(dockerfile): merge buildkit syntax with reference docs#2934
Conversation
crazy-max
force-pushed
the
docs-merge-syntax
branch
2 times, most recently
from
de17d5b to
4c69cdb
Compare
do you think there may be links to those pages, or were they recently renamed to that? (wondering if we need to keep a stub with a link to the new file) |
crazy-max
force-pushed
the
docs-merge-syntax
branch
from
4c69cdb to
3d45bf6
Compare
these files have not changed for ~2 years and links to them are quite low: |
crazy-max
force-pushed
the
docs-merge-syntax
branch
from
3d45bf6 to
102f9d4
Compare
|
@thaJeztah You right for I have put back the md files and updated the link to the new reference docs. |
| ## RUN --mount | ||
|
|
There was a problem hiding this comment.
These are the ones we should look at annotations for (specific css class, e.g.)
| The command is run with no network access (`lo` is still available, but is | ||
| isolated to this process) |
There was a problem hiding this comment.
Perhaps start with "The --network=none option ...."
There was a problem hiding this comment.
I think the title of the section is self-explanatory no?
crazy-max
force-pushed
the
docs-merge-syntax
branch
2 times, most recently
from
15c017f to
9f00474
Compare
|
@thaJeztah PTAL, I would like to move on with this one so I can check how it goes with cross links in the release notes on docs repo docker/docs#15110. Thanks! |
| > The use of `--network=host` is protected by the `network.host` entitlement, | ||
| > which needs to be enabled when starting the buildkitd daemon with | ||
| > `--allow-insecure-entitlement network.host` flag or in [buildkitd config](https://github.com/moby/buildkit/blob/master/docs/buildkitd.toml.md), | ||
| > and for a build request with [`--allow network.host` flag](https://docs.docker.com/engine/reference/commandline/buildx_build/#allow). |
There was a problem hiding this comment.
Could we import some of the buildx docs into this repo as a follow-up? Seems strange to me that we don't document entitlements in buildkit.
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
docs-merge-syntax
branch
from
df987dc to
e7e7e15
Compare
4 participants
follow-up #2902
combine buildkit syntax with reference docs and fix links accordingly in the repo. next follow-up will see how we can split the reference docs and create a changelog so users can have a better understanding of the notable changes.
docs/experimental-syntaxes.mdandfrontend/dockerfile/docs/experimental.mdhave been removed. Don't think we need them anymore.Signed-off-by: CrazyMax crazy-max@users.noreply.github.com