frontend: prevent SecretsUsedInArgOrEnv warning for _FILE/_VERSION ARG/ENV names#6501
Merged
tonistiigi merged 1 commit intomoby:masterfrom Feb 5, 2026
Conversation
Signed-off-by: Jonas Geiler <git@jonasgeiler.com>
Contributor
Author
|
@tonistiigi Hope it's okay if I tag you in this since you also reviewed the original PR #5410 |
jonasgeiler
deleted the
feat/SecretsUsedInArgOrEnv-ignore-file-version
branch
tinovyatkin
added a commit
to wharflab/tally
that referenced
this pull request
Mar 5, 2026
- Normalise buildkit version in SARIF snapshot so dependency bumps don't break tests - Backport moby/buildkit#6534: skip CopyIgnoredFile when .dockerignore contains negated patterns (static analysis is unreliable with exclusions) - Backport moby/buildkit#6501: allow _FILE and _VERSION suffixes in SecretsUsedInArgOrEnv to reduce false positives Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5504
Extending on the PR #5410, I added more allowed tokens to the list.
This should prevent the
SecretsUsedInArgOrEnvwarning when using environment variables like:SESSION_SECRET_FILE- indicating a file path, not an actual secret value (a common pattern in the community)AUTH_MODULE_VERSION- indicating a mere version number, not a secret value