http: add support for checksum requests and pgp signatures for http sources#6527
Merged
tonistiigi merged 2 commits intomoby:masterfrom Feb 20, 2026
Merged
http: add support for checksum requests and pgp signatures for http sources#6527tonistiigi merged 2 commits intomoby:masterfrom
tonistiigi merged 2 commits intomoby:masterfrom
Conversation
github-actions
bot
added
area/llb
area/testing
area/hack
crazy-max
reviewed
Feb 20, 2026
Comment on lines
+613
to
+614
| default: | ||
| return pb.ChecksumRequest_CHECKSUM_ALGO_SHA256 |
Member
There was a problem hiding this comment.
This fallback silently rewrites invalid/unsupported checksum algorithms instead of rejecting them. Could hide client bugs no?
Can we either return an error for unknown values or pass through the raw enum value so the server-side validation can reject it explicitly?
These requests allow computing additional checksum algorithms for the payload of HTTP sources. Optionally suffix can be passed that is added to payload. This is needed to make validation of PGP signatures possible remotely. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Add detached PGP verification for HTTP sources during metadata resolution and expose LLB options/caps/attrs for signature validation. Extract shared OpenPGP verification/parsing logic into util/pgpsign and reuse it from git signing, plus add integration and source-level tests. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
http-checksum-pgp
branch
from
c06594b to
e3fba18
Compare
crazy-max
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These requests allow computing additional checksum algorithms
for the payload of HTTP sources.
Optionally, a suffix can be passed that is added to the payload. This
is needed to make validation of PGP signatures possible remotely.
Add detached PGP verification for HTTP sources during metadata resolution
and expose LLB options/caps/attrs for signature validation.
Extract shared OpenPGP verification/parsing logic into util/pgpsign and
reuse it from git signing, plus add integration and source-level tests.
If preferred, I can open these individually to ease review. I'm mostly interested in the first commit. Second is more for consistency with the Git source.